From 1880369e1a7593d7d13a927612f544c557f9faa9 Mon Sep 17 00:00:00 2001 From: Adam Spofford Date: Thu, 22 Jan 2026 12:49:59 -0800 Subject: [PATCH 1/3] Publish asset canister --- .github/workflows/publish.yml | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 06f8ef6fbd..f72aca71d1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,8 +7,8 @@ name: Publish on: push: tags: - - '[0-9]+.[0-9]+.[0-9]+' - - '[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+' + - "[0-9]+.[0-9]+.[0-9]+" + - "[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+" pull_request: concurrency: @@ -21,7 +21,7 @@ env: # Use the local .curlrc CURL_HOME: . # Disable DFX telemetry - DFX_TELEMETRY: 'off' + DFX_TELEMETRY: "off" jobs: build_dfx: @@ -31,7 +31,13 @@ jobs: matrix: # We build a dynamic-linked linux binary because otherwise HSM support fails with: # Error: IO: Dynamic loading not supported - target: [ x86_64-apple-darwin, aarch64-apple-darwin, x86_64-unknown-linux-gnu, aarch64-unknown-linux-gnu ] + target: + [ + x86_64-apple-darwin, + aarch64-apple-darwin, + x86_64-unknown-linux-gnu, + aarch64-unknown-linux-gnu, + ] include: - os: macos-14-large target: x86_64-apple-darwin @@ -166,7 +172,8 @@ jobs: strategy: fail-fast: false matrix: - name: [ 'x86_64-darwin', 'aarch64-darwin', 'x86_64-linux', 'aarch64-linux' ] + name: + ["x86_64-darwin", "aarch64-darwin", "x86_64-linux", "aarch64-linux"] steps: - uses: actions/checkout@v4 @@ -178,7 +185,7 @@ jobs: with: name: dfx-artifacts-${{ hashFiles('rust-toolchain.toml') }}-${{ matrix.name }} - - name: Upload tarball and sha256 + - name: Upload dfx tarballs and sha256 uses: svenstaro/upload-release-action@v2 with: repo_token: ${{ secrets.GITHUB_TOKEN }} @@ -187,3 +194,10 @@ jobs: tag: ${{ env.VERSION }} prerelease: true make_latest: false + - name: Upload assets canister + uses: svenstaro/upload-release-action@v2 + with: + repo_token: ${{ secrets.GITHUB_TOKEN }} + file: src/distributed/assetstorage.{wasm.gz,did} + file_glob: true + tag: ${{ env.VERSION }} From 2e92bf64a14ba4f6c4c25ef61fd7891a05dcd29c Mon Sep 17 00:00:00 2001 From: Adam Spofford Date: Thu, 22 Jan 2026 12:58:45 -0800 Subject: [PATCH 2/3] undo auto-formatting --- .github/workflows/publish.yml | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f72aca71d1..c2bc100412 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,8 +7,8 @@ name: Publish on: push: tags: - - "[0-9]+.[0-9]+.[0-9]+" - - "[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+" + - '[0-9]+.[0-9]+.[0-9]+' + - '[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+' pull_request: concurrency: @@ -21,7 +21,7 @@ env: # Use the local .curlrc CURL_HOME: . # Disable DFX telemetry - DFX_TELEMETRY: "off" + DFX_TELEMETRY: 'off' jobs: build_dfx: @@ -31,13 +31,7 @@ jobs: matrix: # We build a dynamic-linked linux binary because otherwise HSM support fails with: # Error: IO: Dynamic loading not supported - target: - [ - x86_64-apple-darwin, - aarch64-apple-darwin, - x86_64-unknown-linux-gnu, - aarch64-unknown-linux-gnu, - ] + target: [ x86_64-apple-darwin, aarch64-apple-darwin, x86_64-unknown-linux-gnu, aarch64-unknown-linux-gnu ] include: - os: macos-14-large target: x86_64-apple-darwin @@ -172,8 +166,7 @@ jobs: strategy: fail-fast: false matrix: - name: - ["x86_64-darwin", "aarch64-darwin", "x86_64-linux", "aarch64-linux"] + name: [ 'x86_64-darwin', 'aarch64-darwin', 'x86_64-linux', 'aarch64-linux' ] steps: - uses: actions/checkout@v4 From 1d2cba7015a0a6c0325defeccfb802f0e3477fb3 Mon Sep 17 00:00:00 2001 From: Adam Spofford Date: Thu, 22 Jan 2026 13:29:12 -0800 Subject: [PATCH 3/3] Publish platform-independent files as separate step --- .github/workflows/publish.yml | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c2bc100412..278872d4fd 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,8 +7,8 @@ name: Publish on: push: tags: - - '[0-9]+.[0-9]+.[0-9]+' - - '[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+' + - "[0-9]+.[0-9]+.[0-9]+" + - "[0-9]+.[0-9]+.[0-9]+-[A-Za-z]+.[0-9]+" pull_request: concurrency: @@ -21,7 +21,7 @@ env: # Use the local .curlrc CURL_HOME: . # Disable DFX telemetry - DFX_TELEMETRY: 'off' + DFX_TELEMETRY: "off" jobs: build_dfx: @@ -31,7 +31,13 @@ jobs: matrix: # We build a dynamic-linked linux binary because otherwise HSM support fails with: # Error: IO: Dynamic loading not supported - target: [ x86_64-apple-darwin, aarch64-apple-darwin, x86_64-unknown-linux-gnu, aarch64-unknown-linux-gnu ] + target: + [ + x86_64-apple-darwin, + aarch64-apple-darwin, + x86_64-unknown-linux-gnu, + aarch64-unknown-linux-gnu, + ] include: - os: macos-14-large target: x86_64-apple-darwin @@ -166,7 +172,8 @@ jobs: strategy: fail-fast: false matrix: - name: [ 'x86_64-darwin', 'aarch64-darwin', 'x86_64-linux', 'aarch64-linux' ] + name: + ["x86_64-darwin", "aarch64-darwin", "x86_64-linux", "aarch64-linux"] steps: - uses: actions/checkout@v4 @@ -187,6 +194,16 @@ jobs: tag: ${{ env.VERSION }} prerelease: true make_latest: false + publish-assets: + runs-on: ubuntu-latest + if: github.ref_type == 'tag' + needs: publish + steps: + - uses: actions/checkout@v4 + + - name: Setup environment variables + run: echo "VERSION=$GITHUB_REF_NAME" >> $GITHUB_ENV + - name: Upload assets canister uses: svenstaro/upload-release-action@v2 with: