Parsed Method from Nodeset.xml not working

[johannwesely]

Hello,

i use uanodeset to parse an xml file generated by Siome. When i add a simple method in Siome with String as input Argument 1 and parse the xml i get some errors in UaExpert. I know that i need an Invocation handler but i dont come this far to even call the method. Can you give me an example what i need to get a parsed method to run correctly ?

Greetings Johann

[kevinherron]

Can you provide a sample UANodeSet file that defines an Object + Method I can use to reproduce/test? This may be an issue for https://github.com/digitalpetri/uanodeset but I'm not sure yet.

[kevinherron]

@johannwesely can you add screenshots of the Attributes pane in UaExpert with each of the InputArguments and OutputArguments Nodes selected?

[johannwesely]

Hello,
here are the attribute panes


Im sorry but i played arround with the nodesetfile and now i cant reproduce the error in the screen i sent before. So i think something was wrong with the siome export. But i still have the problem that the caller popup in uaexpert is empty.
Greetings Johann

[kevinherron]

Strange, looks like all the pieces are in place.

Can you get a Wireshark capture with an unsecured connection that captures you trying to invoke the method?

[kevinherron]

Did you change the datatypes of the arguments? In the NodeSet XML you sent me one of them was String and the other Variant, but in the screenshots it looks like they're both NodeId.

[johannwesely]

I use the exact same file as the one i send you per PM. Attached is the wireshark of a method call
custom_method_call.zip

[kevinherron]

Well there seems to be some issue with the way the input and/or output argument values are encoded:

Not sure I'll have time to try to reproduce this today, been in all day meetings all week for a work summit thing.

[johannwesely]

If there is something i can do to help let me know.

[kevinherron]

I just pushed what I think should fix it to the uanodeset repo: digitalpetri/uanodeset@f0ff13c

Check that out, mvn clean install, update your dependency to 0.5-SNAPSHOT, and let me know if it fixed it for you.

[johannwesely]

Hi Kevin,
i tested the uanodeset 0.5-Snapshot and now i can call the method from UaExpert. But when i want to get the InputArguments from parsed UaMethod Node i get null i debugged it to line 384 in UANode where i get this exception: Cannot cast [Lorg.eclipse.milo.opcua.stack.core.types.builtin.ExtensionObject; to [Lorg.eclipse.milo.opcua.stack.core.types.structured.Argument;
so i think there is still something wrong. when i get propertyNodes from UAMethodNode they exist

Greetings Johann

[kevinherron]

Hmm, I need to figure out how to test this. Even if your NodeSet was public it depends on like 17 others so it doesn't load quite right.

I think the fix is something like this in Milo (+ the uanodeset change):

Subject: [PATCH] Handle decoding of ExtensionObject in UaNode properties

- Updated `getProperty` logic to decode `ExtensionObject` and `ExtensionObject[]` to their underlying types using the server's static encoding context.
- Added handling for `Matrix` containing `ExtensionObject[]`, decoding elements and re-creating the matrix with decoded values.
---
Index: opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNode.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNode.java b/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNode.java
--- a/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNode.java	(revision b7e3da14d2eb7da0462b0a84dd5b4e1eb336096f)
+++ b/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNode.java	(date 1763729862041)
@@ -13,6 +13,7 @@
 import static org.eclipse.milo.opcua.stack.core.types.builtin.unsigned.Unsigned.uint;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Objects;
@@ -34,9 +35,12 @@
 import org.eclipse.milo.opcua.stack.core.StatusCodes;
 import org.eclipse.milo.opcua.stack.core.UaException;
 import org.eclipse.milo.opcua.stack.core.UaRuntimeException;
+import org.eclipse.milo.opcua.stack.core.types.UaStructuredType;
 import org.eclipse.milo.opcua.stack.core.types.builtin.DataValue;
 import org.eclipse.milo.opcua.stack.core.types.builtin.ExpandedNodeId;
+import org.eclipse.milo.opcua.stack.core.types.builtin.ExtensionObject;
 import org.eclipse.milo.opcua.stack.core.types.builtin.LocalizedText;
+import org.eclipse.milo.opcua.stack.core.types.builtin.Matrix;
 import org.eclipse.milo.opcua.stack.core.types.builtin.NodeId;
 import org.eclipse.milo.opcua.stack.core.types.builtin.QualifiedName;
 import org.eclipse.milo.opcua.stack.core.types.builtin.Variant;
@@ -380,7 +384,26 @@
       QualifiedName browseName = new QualifiedName(namespaceIndex, property.getBrowseName());
 
       try {
-        return getProperty(browseName).map(property.getJavaType()::cast);
+        Object v = getProperty(browseName).orElse(null);
+
+        if (v instanceof ExtensionObject xo) {
+          v = xo.decode(context.getServer().getStaticEncodingContext());
+        } else if (v instanceof ExtensionObject[] xos) {
+          v =
+              Arrays.stream(xos)
+                  .map(xo -> xo.decode(context.getServer().getStaticEncodingContext()))
+                  .toArray();
+        } else if (v instanceof Matrix matrix
+            && matrix.getElements() instanceof ExtensionObject[] xos) {
+
+          UaStructuredType[] decoded = new UaStructuredType[xos.length];
+          for (int i = 0; i < xos.length; i++) {
+            decoded[i] = xos[i].decode(context.getServer().getStaticEncodingContext());
+          }
+          v = new Matrix(decoded, matrix.getDimensions());
+        }
+
+        return Optional.ofNullable(property.getJavaType().cast(v));
       } catch (Throwable t) {
         return Optional.empty();
       }

[johannwesely]

I made a minimized Version of the nodeset.xml maybe this helps for testing.
ToxUaNodeset_mini.zip
i try your patch and report here.

[johannwesely]

hmm Cannot cast [Ljava.lang.Object; to [Lorg.eclipse.milo.opcua.stack.core.types.structured.Argument; in this line

v looks like this:
Argument[name='Arg1', dataType=NodeId{ns=0, id=12}, valueRank=-1, arrayDimensions=[], description=LocalizedText[locale=null, text=input]]

[kevinherron]

Yeah figures... need to be more careful with the generics on the array and matrix cases I think.

Like this logic:

milo/opc-ua-sdk/sdk-client/src/main/java/org/eclipse/milo/opcua/sdk/client/nodes/UaNode.java

Lines 1372 to 1383 in b7e3da1

	} else if (o instanceof ExtensionObject[] xos) {
	Class<?> componentType = clazz.getComponentType();
	Object array = Array.newInstance(componentType, xos.length);
	for (int i = 0; i < xos.length; i++) {
	ExtensionObject xo = xos[i];
	Object decoded = xo.decode(client.getStaticEncodingContext());
	Array.set(array, i, componentType.cast(decoded));
	}

I think I know how to create an integration test for this, so I'll work on that today and try to handle all the corner cases correctly.

[kevinherron]

#1662 / #1663

[kevinherron]

@johannwesely this was merged, latest Milo SNAPSHOT + latest uanodeset SNAPSHOT should work?

[johannwesely]

Im allready up and running.
Works like a charm 😃
Thank you