The `k=RETRIEVAL_K` should be passed to the `as_retriever` method, not the `invoke`

[amjadmajid]

The k=RETRIEVAL_K should be passed to the as_retriever method, not the invoke, as in these examples from LangChain https://reference.langchain.com/python/langchain_core/vectorstores/#langchain_core.vectorstores.base.VectorStore.as_retriever

retriever = vectorstore.as_retriever(search_kwargs={"k": RETRIEVAL_K})

llm_engineering/week5/implementation/answer.py

Line 30 in ed0118b

retriever = vectorstore.as_retriever()

[ed-donner]

Hello @amjadmajid -
The fact that as_retriever can include a search_kwargs argument, as in some examples, does necessarily mean that this is the ONLY way to do it, no?
Have you established that the approach in the repo:

retriever = vectorstore.as_retriever() 
retriever.invoke("Who is Avery?", k=2)

Doesn't work? Have you tested this and confirmed that it doesn't work?
Or are you saying that you think:

retriever = vectorstore.as_retriever(search_kwargs={"k": 2}) 
retriever.invoke("Who is Avery?")

is more idiomatic than:

retriever = vectorstore.as_retriever() 
retriever.invoke("Who is Avery?", k=2)

Many thanks
Ed