potentially undefined variable in extract.slope

[hugomflavio]

Hi!

I was reading through the code of extract.slope, and I couldn't find where the variable 'time' in the line below was defined.

FishResp-Rpackage/R/extract.slope.R

Line 157 in a9c42ea

valid <- cl2$Freq>=0.1*length(time)

Could it be a lost variable?

Thanks!

[hugomflavio]

I've tracked this bug to the original R appendix in the Chabot 2016 paper.

[hugomflavio]

I've read the paper back to back but couldn't understand what those lines should do. I've posted a comment on the ResearchGate page for that paper. Perhaps we'll get an answer that way.

https://www.researchgate.net/publication/290623162_The_determination_of_standard_metabolic_rate_in_fishes/comments

[hugomflavio]

Chabot got back to me on ResearchGate and confirmed that it should be 10% of the number of measurements. Changing to e.g.

valid <- cl2$Freq >= 0.1 * nrow(chamber.df) 

Should fix it.