From bd43d0dac42f0bb40dc074bdf61f5cedaac52907 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 16 Oct 2022 05:50:57 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../pcode/datasets/loader/femnist.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/codes/FedDF-code/pcode/datasets/loader/femnist.py b/codes/FedDF-code/pcode/datasets/loader/femnist.py index b8a122f..634fb23 100644 --- a/codes/FedDF-code/pcode/datasets/loader/femnist.py +++ b/codes/FedDF-code/pcode/datasets/loader/femnist.py @@ -842,7 +842,26 @@ def tar_compress_folder(folder_path): def tar_decompress_folder(file_path): with tarfile.open(file_path) as tar: subdir_and_files = [tarinfo for tarinfo in tar.getmembers()] - tar.extractall(members=subdir_and_files) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, members=subdir_and_files) def iid_divide(l, g):