Skip to content

Let get_pairwise_comparison() run with two models? #1022

@athowes

Description

@athowes

Currently get_pairwise_comparison() will stop you if you have two models:

# check there are enough comparators
if (length(setdiff(comparators, baseline)) < 2) {
#nolint start: keyword_quote_linter
cli_abort(
c(
"!" = "More than one non-baseline model is needed to compute
pairwise compairisons."
)
)
#nolint end
}

While it's fair enough to say that you don't really need relative scores if you just have two models, there is not a conceptual problem with computing a comparison between two models. (Also if you are running more models and setting up the infrastructure with just the first one!)

So I think this should be a warning rather than an abort.

(At the moment, my solution is to create a fake model with one row, append it on, then remove it afterwards.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions