remove extra tests

Author: tac0turtle

test/e2e/evm_sequencer_e2e_test.go

@@ -40,46 +40,6 @@ import (
 	"github.com/rollkit/rollkit/execution/evm"
 )
 
-// TestEvmSequencerE2E tests the basic end-to-end functionality of a single EVM sequencer node.
-//
-// Test Flow:
-// 1. Sets up Local DA layer for data availability
-// 2. Starts EVM (Reth) engine via Docker Compose
-// 3. Initializes and starts the sequencer node with proper configuration
-// 4. Submits a single test transaction to the EVM
-// 5. Verifies the transaction is successfully included in a block
-//
-// Validation:
-// - Sequencer node starts successfully and becomes responsive
-// - Transaction submission works correctly
-// - Transaction is included in EVM block with success status
-// - Block production occurs within expected timeframe
-//
-// This test validates the core functionality of Rollkit's EVM integration
-// and ensures basic transaction processing works correctly.
-func TestEvmSequencerE2E(t *testing.T) {
-	flag.Parse()
-	workDir := t.TempDir()
-	nodeHome := filepath.Join(workDir, "evm-agg")
-	sut := NewSystemUnderTest(t)
-
-	// Setup sequencer
-	genesisHash := setupSequencerOnlyTest(t, sut, nodeHome)
-	t.Logf("Genesis hash: %s", genesisHash)
-
-	// Submit a transaction to EVM
-	lastNonce := uint64(0)
-	tx := evm.GetRandomTransaction(t, TestPrivateKey, TestToAddress, DefaultChainID, DefaultGasLimit, &lastNonce)
-	evm.SubmitTransaction(t, tx)
-	t.Log("Submitted test transaction to EVM")
-
-	// Wait for block production and verify transaction inclusion
-	require.Eventually(t, func() bool {
-		return evm.CheckTxIncluded(t, tx.Hash())
-	}, 15*time.Second, 500*time.Millisecond)
-	t.Log("Transaction included in EVM block")
-}
-
 // TestEvmMultipleTransactionInclusionE2E tests high-throughput transaction processing
 // to ensure multiple transactions submitted in quick succession are all included
 // and maintain correct ordering without any loss or corruption.
@@ -256,189 +216,6 @@ func TestEvmMultipleTransactionInclusionE2E(t *testing.T) {
 	t.Logf("✅ Test PASSED: All %d transactions included in correct nonce order", numTxs)
 }
 
-// TestEvmDoubleSpendNonceHandlingE2E tests the system's ability to handle transactions with
-// duplicate nonces correctly, ensuring that double-spending is prevented.
-//
-// Test Purpose:
-// - Ensure the system correctly handles transactions with duplicate or out-of-order nonces
-// - Prevent double-spending scenarios by rejecting duplicate nonce transactions
-// - Validate that only one transaction per nonce is included in the blockchain
-//
-// Test Flow:
-// 1. Sets up Local DA layer and EVM sequencer
-// 2. Submits two transactions with the same nonce from the same account
-// 3. Waits for transaction processing and block inclusion
-// 4. Verifies that only one transaction is included in the blockchain
-// 5. Confirms the rejected transaction is not included in any block
-// 6. Validates account nonce is incremented correctly (only once)
-//
-// Expected Behavior:
-// - First transaction submitted should be included successfully
-// - Second transaction with same nonce should be rejected/not included
-// - Account nonce should only increment once
-// - No double-spending should occur
-// - System should remain stable and continue processing subsequent transactions
-//
-// This test validates Rollkit's nonce handling and double-spend prevention mechanisms.
-func TestEvmDoubleSpendNonceHandlingE2E(t *testing.T) {
-	flag.Parse()
-	workDir := t.TempDir()
-	nodeHome := filepath.Join(workDir, "evm-agg")
-	sut := NewSystemUnderTest(t)
-
-	// Setup sequencer
-	genesisHash := setupSequencerOnlyTest(t, sut, nodeHome)
-	t.Logf("Genesis hash: %s", genesisHash)
-
-	// Connect to EVM
-	client, err := ethclient.Dial(SequencerEthURL)
-	require.NoError(t, err, "Should be able to connect to EVM")
-	defer client.Close()
-
-	// Create two transactions with the same nonce (double-spend attempt)
-	const duplicateNonce = uint64(0)
-	lastNonce := duplicateNonce
-
-	// Create first transaction with nonce 0
-	tx1 := evm.GetRandomTransaction(t, TestPrivateKey, TestToAddress, DefaultChainID, DefaultGasLimit, &lastNonce)
-
-	// Reset nonce to create second transaction with same nonce
-	lastNonce = duplicateNonce
-	tx2 := evm.GetRandomTransaction(t, TestPrivateKey, TestToAddress, DefaultChainID, DefaultGasLimit, &lastNonce)
-
-	// Verify both transactions have the same nonce
-	require.Equal(t, tx1.Nonce(), tx2.Nonce(), "Both transactions should have the same nonce")
-	require.Equal(t, duplicateNonce, tx1.Nonce(), "Transaction 1 should have nonce %d", duplicateNonce)
-	require.Equal(t, duplicateNonce, tx2.Nonce(), "Transaction 2 should have nonce %d", duplicateNonce)
-
-	t.Logf("Created two transactions with same nonce %d:", duplicateNonce)
-	t.Logf("  TX1 Hash: %s", tx1.Hash().Hex())
-	t.Logf("  TX2 Hash: %s", tx2.Hash().Hex())
-
-	// Submit both transactions in quick succession
-	evm.SubmitTransaction(t, tx1)
-	t.Logf("Submitted first transaction (TX1): %s", tx1.Hash().Hex())
-
-	// Small delay between submissions to simulate realistic scenario
-	time.Sleep(20 * time.Millisecond)
-
-	// Try to submit the second transaction - this should fail with "replacement transaction underpriced" or similar
-	// We expect this to fail, so we'll handle the error gracefully
-	func() {
-		defer func() {
-			if r := recover(); r != nil {
-				t.Logf("Second transaction submission failed as expected: %v", r)
-			}
-		}()
-		// This should fail, but we'll try anyway to test the system's response
-		err := func() (err error) {
-			defer func() {
-				if r := recover(); r != nil {
-					err = fmt.Errorf("transaction submission failed: %v", r)
-				}
-			}()
-			// Use a lower-level approach to avoid panics
-			client, clientErr := ethclient.Dial(SequencerEthURL)
-			if clientErr != nil {
-				return clientErr
-			}
-			defer client.Close()
-
-			return client.SendTransaction(context.Background(), tx2)
-		}()
-
-		if err != nil {
-			t.Logf("Second transaction (TX2) rejected as expected: %v", err)
-		} else {
-			t.Logf("Second transaction (TX2) submitted: %s", tx2.Hash().Hex())
-		}
-	}()
-
-	// Wait for block production and check transaction inclusion
-	ctx := context.Background()
-
-	t.Log("Waiting for transactions to be processed...")
-	time.Sleep(2 * time.Second)
-
-	// Check current block height to see if blocks are being produced
-	blockNumber, err := client.BlockNumber(ctx)
-	if err != nil {
-		t.Logf("Warning: Could not get block number: %v", err)
-	} else {
-		t.Logf("Current block number: %d", blockNumber)
-	}
-
-	// Check which transaction was included
-	var includedTxHash common.Hash
-	var rejectedTxHash common.Hash
-
-	// Get hash values for easier reference
-	tx1Hash := tx1.Hash()
-	tx2Hash := tx2.Hash()
-
-	// Check TX1
-	receipt1, err1 := client.TransactionReceipt(ctx, tx1Hash)
-	tx1Included := err1 == nil && receipt1 != nil && receipt1.Status == 1
-
-	// Check TX2
-	receipt2, err2 := client.TransactionReceipt(ctx, tx2Hash)
-	tx2Included := err2 == nil && receipt2 != nil && receipt2.Status == 1
-
-	// Determine which transaction was included and which was rejected
-	if tx1Included && !tx2Included {
-		includedTxHash = tx1Hash
-		rejectedTxHash = tx2Hash
-		t.Logf("✅ TX1 included, TX2 rejected (as expected)")
-	} else if tx2Included && !tx1Included {
-		includedTxHash = tx2Hash
-		rejectedTxHash = tx1Hash
-		t.Logf("✅ TX2 included, TX1 rejected (as expected)")
-	} else if tx1Included && tx2Included {
-		t.Errorf("❌ BOTH transactions were included - double-spend not prevented!")
-		t.Errorf("  TX1: %s (block: %d)", tx1Hash.Hex(), receipt1.BlockNumber.Uint64())
-		t.Errorf("  TX2: %s (block: %d)", tx2Hash.Hex(), receipt2.BlockNumber.Uint64())
-		require.Fail(t, "Double-spend prevention failed - both transactions with same nonce were included")
-	} else {
-		t.Errorf("❌ NEITHER transaction was included")
-		t.Errorf("  TX1 error: %v", err1)
-		t.Errorf("  TX2 error: %v", err2)
-		require.Fail(t, "Neither transaction was included - system may have failed")
-	}
-
-	// Verify exactly one transaction was included
-	require.True(t, (tx1Included && !tx2Included) || (tx2Included && !tx1Included),
-		"Exactly one transaction should be included, the other should be rejected")
-
-	t.Logf("Double-spend prevention working correctly:")
-	t.Logf("  ✅ Included transaction: %s", includedTxHash.Hex())
-	t.Logf("  ❌ Rejected transaction: %s", rejectedTxHash.Hex())
-
-	// Verify the account nonce (note: in test environment, nonce behavior may vary)
-	fromAddress := common.HexToAddress(TestToAddress)
-
-	// Wait for the transaction to be fully processed and nonce updated
-	time.Sleep(500 * time.Millisecond)
-
-	currentNonce, err := client.NonceAt(ctx, fromAddress, nil)
-	require.NoError(t, err, "Should be able to get current nonce")
-
-	expectedNonce := duplicateNonce + 1
-	if currentNonce == expectedNonce {
-		t.Logf("✅ Account nonce correctly incremented: %d -> %d", duplicateNonce, currentNonce)
-	} else {
-		// In test environments, nonce behavior might be different
-		// The important thing is that double-spend was prevented
-		t.Logf("⚠️  Account nonce: expected %d, got %d (this is acceptable in test environment)", expectedNonce, currentNonce)
-		t.Logf("✅ Main test objective achieved: double-spend prevention working correctly")
-	}
-
-	t.Logf("✅ Test PASSED: Double-spend prevention working correctly")
-	t.Logf("   - Only 1 of 2 transactions with same nonce was included")
-	t.Logf("   - Double-spend prevention mechanism functioning properly")
-	t.Logf("   - EVM correctly rejected duplicate nonce transaction")
-	t.Logf("   - System maintains transaction integrity and prevents double-spending")
-}
-
 // TestEvmInvalidTransactionRejectionE2E tests the system's ability to properly reject
 // various types of invalid transactions and ensure they are not included in any blocks.
 //