vars are detected as HOC

[valerauko]

When keeping references to view functions as vars (for hot reload reasons) hsx detects them as HOC and prints a warning.

Since the warning talks about anonymous functions I was pretty confused what it could be referring to.

[wavejumper]

Yeah, in the case where you have a top-level binding like:

(def button
  (fn [props] ...))

HSX detects these as a HOC which as you have identified is a false positive. The log talks about this (kinda), but I can totally see how it's confusing. We mostly had this aggressive log in place to crunch down on the anonymous components we had in our codebase when migrating.

There is a component macro which compiles a cljs fn to a 'hsx proxy fn' (undocumented), so you can:

(def button
  (hsx/component "Button" (fn [props] ...))

And the log warnings should stop. As a bonus your component will have a nice display name in the React profiler 😄

There's also a way to disable that warning, by annotating the component call with some metadata:

[^:hoc (fn [props] [:div props "Hello world"]) { .... } ] 

Anyways, I'll cut a release of HSX that that makes the HOC logging configurable and turns it off by default.

[valerauko]

In our case the components are regular defn's, they are just passed around as vars (otherwise reitit's route definition "closes over" the function and hot reloading doesn't work properly)

(defn view
  [_match]
  [:div "foo"])

;; then in the route defs
["/foo" {:name ::foo :view #'view}]

I can work around this by derefing the var where it's used, but it's something that worked "out of the box" with reagent

[wavejumper]

Perfect, thanks for the example code. I will investigate and cut a release that is less spam-y with logs.