Improve "You are using an insecure browser!" Checks

[dsmith4-godaddy]

Recently-updated iOS devices (iPhones/iPads) now incorrectly trigger the BrowseHappy "You are using an insecure browser" warning. This appears to be addressed in the already-merged #214, but there hasn't been a release in the last several weeks. Thus, anyone keeping their devices up-to-date is seeing a warning that paradoxically claims their device is out-of-date.

A new release will also confirm that the version-number update code added in the last update works 🤣

[rmccue]

🤔 The check is meant to include future versions as well, so we should check why this isn't working properly.

[joedolson]

The version changed to 18.6.2 on August 20th, but the character class in the browser regex was [45], so it didn't recognize that.

So I'd say that the checks don't reliably include future versions. The current version is [4-6], so it's fine now.

I think we'll need to do something to improve this or we need to start doing regular incremental point releases so that the Regex is always up to date.

[joedolson]

This needs discussing, because we can address it with no code changes if we plan on regular point releases; but if we want to modify the regex, that's more of a hassle.

[rmccue]

Specifically, the query includes unreleased versions

[rmccue]

We could offer an API on api.fair.pm to get the regex, then store it in an option. We could keep a copy of it hardcoded as well. This would preserve user privacy by never sending users' user agent elsewhere (as browsehappy does).

[joedolson]

A API would work pretty well. Local version for fallback, API query for updating on a schedule. Easier than adding unnecessary releases, certainly.

[Ipstenu]

This gets automated fixes but yes, we should look into an API call instead.

[joedolson]

Re-opening this to try and find a better resolution. This was closed with no changes previously, because technically everything is working as expected; but it still leaves us with significant periods between releases where we might be throwing invalid flags.