Wake Event Updates Implementation

[LswaN58]

• Before each new event creation in the codebase, ensure that UpdateGameState gets called. fixed by 01a636c

[LswaN58]

Wanted to make a note here about an issue I ran into while testing some of the other implementations in develop.

I went to the reef, and scanned and counted all critters there. Then I tried to start Turtle Population (after having already completed the counting task), I got the following error:

Assertion Failed!
Location: Aqua.AnalyticsService.LogCompleteTask (BeauUtil.StringHash32 jobId, BeauUtil.StringHash32 inTaskId)
@(<00000000000000000000000000000000>:0)
Condition: NullReferenceException: Object reference not set to an instance of an object.

I also saved the crash report, I'll upload it in the next comment. It looks like this is an issue with the updates to logging pre-completed tasks at the time a job is accepted.

@BeauchesneFieldDay or @ameliajmoser please let me know if you have any questions or insights about the issue.

[LswaN58]

Crash log:

wake-crash-log_turtle-pop-tasks-previously-completed.htm

[XanGrab]

From Autumn:

• Document changes to events
• Ensure anything using GameState is updated appropriately and that any event changes are being used appropriately

Question for @LswaN58: When in-game (if at all) do we currently want to log the current bestiary?

[jmmathew-cpu]

@LswaN58 Can you verify that this is working and move it into the "Ready for Implementation" pile if it is?

[LswaN58]

Question for @LswaN58: When in-game (if at all) do we currently want to log the current bestiary?

@XanGrab I'd have to double-check what Autumn and I had in our document for game state elements, but my instinct is to never log the full bestiary. Given how big it gets, I don't want our data to get harder to work with the longer a player is active. I think we'd be better off ensuring all events related to something being added to the bestiary have a consistent structure to make reconstruction of the data easy.

In other words, if we take the hypothetical structure of a full bestiary, let's ensure that the event for adding a new creature holds the same structure in event_data as the creature would have in its entry in the full bestiary. And we'll do something similar for adding facts, environments, whatever else is considered "bestiary" data. Make sense?

[LswaN58]

@LswaN58 Can you verify that this is working and move it into the "Ready for Implementation" pile if it is?

@jmmathew-cpu given the scope of changes we made to logging, it will take me some time to verify everything. I will plan to spend some time playing through the game over break, to check our changes. I should be able to give a firm yes/no early in the first week back post-break.

[XanGrab]

Key Changes:

• introduction of GameState struct for logging (see 36a7bae)
• reorganization of Events in AnalyticsService.cs (based partially on GameState changes)
• eliminate logging of entire bestiary entry