diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index a065ea3..b564848 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -20,6 +20,10 @@ jobs: - name: Install run: | npm install --workspaces + # build packages synchronously to ensure sibling dependencies are built. + # @TODO - see if it's possible to do this better + # first build the one that consumed by siblings, then just build all + npm run build --workspace="@foo-software/ghost-graphql" npm run build --workspaces --if-present - name: Generate Schema run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3a9d51f..6c9c506 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,12 @@ jobs: scope: '@foo-software' - name: Install run: | - npm install --workspaces --include-workspace-root + npm install --workspaces + # build packages synchronously to ensure sibling dependencies are built. + # @TODO - see if it's possible to do this better + # first build the one that consumed by siblings, then just build all + npm run build --workspace="@foo-software/ghost-graphql" + npm run build --workspaces --if-present - name: Integration Tests run: | cd packages/ghost-graphql-integration-tests diff --git a/package-lock.json b/package-lock.json index f943da1..a496b73 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5,7 +5,6 @@ "packages": { "": { "name": "root", - "hasInstallScript": true, "workspaces": [ "./packages/*" ], @@ -18,6 +17,9 @@ "husky": "^4.2.5", "lint-staged": "^10.4.2", "prettier": "^2.0.5" + }, + "engines": { + "node": ">=16.20.2 <17" } }, "node_modules/@ampproject/remapping": { @@ -11438,6 +11440,7 @@ "packages/ghost-graphql-server": { "name": "@foo-software/ghost-graphql-server", "version": "2.0.17", + "hasInstallScript": true, "dependencies": { "@foo-software/ghost-graphql": "*", "@types/meow": "^5.0.0", diff --git a/packages/ghost-graphql-ci-tools/src/bin/publish-packages.ts b/packages/ghost-graphql-ci-tools/src/bin/publish-packages.ts index 6b80800..92a3d58 100644 --- a/packages/ghost-graphql-ci-tools/src/bin/publish-packages.ts +++ b/packages/ghost-graphql-ci-tools/src/bin/publish-packages.ts @@ -7,7 +7,7 @@ const run = async () => { console.log('⌛ version, git commit and push...'); // @TODO - dynamically pull from somewhere (maybe utilize conventional commits) - npm.version({ versionType: 'minor' }); + npm.version({ versionType: 'major' }); git.push(); console.log('✅ version, git commit and push completed'); diff --git a/packages/ghost-graphql-integration-tests/package.json b/packages/ghost-graphql-integration-tests/package.json index 718bea7..1cf2712 100644 --- a/packages/ghost-graphql-integration-tests/package.json +++ b/packages/ghost-graphql-integration-tests/package.json @@ -7,7 +7,6 @@ "main": "dist/index.js", "types": "dist/index.d.ts", "scripts": { - "build": "echo build", "test": "jest" }, "devDependencies": {