diff --git a/loader/loader/util.py b/loader/loader/util.py index 23b8b38..a552dac 100644 --- a/loader/loader/util.py +++ b/loader/loader/util.py @@ -116,7 +116,26 @@ def extractPackage(path): os.makedirs(folderPath) - tar.extractall(folderPath) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, folderPath) if not noTopArchive: folderPath = os.path.join(folderPath, topLevelFolderName)