Skip to content

x, y parameters are unsigned; C API has defined behavior for values under 0. #62

@mpatraw

Description

@mpatraw

Since the C API has well defined behavior for values under 0 for the x,y coordinates, I feel like it's incorrect to place such a restriction on the Rust API via usize. Here's the relevant termbox code: https://github.com/nsf/termbox/blob/master/src/termbox.c#L226

void tb_put_cell(int x, int y, const struct tb_cell *cell)
{
    if ((unsigned)x >= (unsigned)back_buffer.width)
        return;
    if ((unsigned)y >= (unsigned)back_buffer.height)
        return;
    CELL(&back_buffer, x, y) = *cell;
}

This also would allow for print to be used offscreen and correctly clip the few first characters off screen without any funky splice logic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions