x/tools/gopls: modernizer for sync.OnceValues

[adonovan]

Some complex uses of sync.Once can be much simplified using OnceValues; see
https://go.dev/cl/728860 for example. Let's add a modernizer that recognizes the pattern.

[gabyhelp]

Related Issues

• x/tools/gopls/internal/analysis/modernize: add modernizer for WaitGroup.Go #73059 (closed)
• net/http: use sync.OnceFunc, sync.OnceValue #69634 (closed)
• x/tools/gopls/internal/analysis: add "modernizer" analyzers #70815 (closed)
• x/tools/go/analysis/passes/modernize: publish #75266 (closed)
• x/tools/gopls/internal/analysis/modernize: add pass to use reflect.TypeAssert #75422

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[linsite]

May I request to be assigned to this task? I’m new to gopls, but I’d like to give it a try if it’s not too complicated.

[adonovan]

May I request to be assigned to this task? I’m new to gopls, but I’d like to give it a try if it’s not too complicated.

By all means! Thanks.

Before you start coding, I suggest you start by posting a brief plan here for the patterns you want to match, so that we can try to enumerate all the necessary safety conditions, reducing surprises and the need for rewrites.

[linsite]

May I request to be assigned to this task? I’m new to gopls, but I’d like to give it a try if it’s not too complicated.

By all means! Thanks.

Before you start coding, I suggest you start by posting a brief plan here for the patterns you want to match, so that we can try to enumerate all the necessary safety conditions, reducing surprises and the need for rewrites.

Thanks for the guidance. I'll post them later.