You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Describe the bug
Creating a proposal with an empty commit link currently leads to the application error: "Please specify a valid commit link".
To Reproduce
Steps to reproduce the behavior:
Go to any vulnerability entry (with an existing commit link).
Propose changes and leave commit link empty or remove it.
Submit changes.
Expected behavior
Commit links are supposed to be optional.
Additional context data/models/vulnerability.py has a commit_link.setter. Using just a return for empty strings leads to an error in the diff algorithm in data/models/base.py where it would not recognize that the commit link has been changed and reject the proposal.