reduce log leve. align more with OH guidance on logging

Signed-off-by: Eugen Freiter <freiter@gmx.de>

Author: Eugen Freiter

src/main/java/io/github/hapjava/accessories/HomekitAccessory.java

@@ -7,7 +7,7 @@
 import java.util.concurrent.CompletableFuture;
 
 /**
- * Base interface for all Homekit Accessories. You can implement this interface directly, but most
+ * Base interface for all HomeKit Accessories. You can implement this interface directly, but most
  * users will prefer to use the more full featured interfaces in {@link
  * io.github.hapjava.accessories} which include a default implementation of {@link #getServices()}.
  *
@@ -67,7 +67,7 @@ public interface HomekitAccessory {
 
   /**
    * The collection of Services this accessory supports. Services are the primary way to interact
-   * with the accessory via Homekit. Besides the Services offered here, the accessory will
+   * with the accessory via HomeKit. Besides the Services offered here, the accessory will
    * automatically include the required information service.
    *
    * <p>This method will only be useful if you're implementing your own accessory type. For the

src/main/java/io/github/hapjava/characteristics/Characteristic.java

@@ -8,7 +8,7 @@
 /**
  * Interface for the characteristics provided by a Service.
  *
- * <p>Characteristics are the lowest level building block of the Homekit Accessory Protocol. They
+ * <p>Characteristics are the lowest level building block of the HomeKit Accessory Protocol. They
  * define variables that can be retrieved or set by the remote client. Most consumers of this
  * library will be better served by using one of the characteristic classes in {@link
  * io.github.hapjava.characteristics} when creating custom accessory types (the standard accessories
@@ -28,7 +28,7 @@ public interface Characteristic {
   void supplyValue(JsonObjectBuilder characteristicBuilder);
 
   /**
-   * Creates the JSON representation of the characteristic, in accordance with the Homekit Accessory
+   * Creates the JSON representation of the characteristic, in accordance with the HomeKit Accessory
    * Protocol.
    *
    * @param iid The instance ID of the characteristic to be included in the serialization.

src/main/java/io/github/hapjava/characteristics/impl/base/BaseCharacteristic.java

@@ -77,7 +77,7 @@ public final CompletableFuture<JsonObject> toJson(int iid) {
   }
 
   /**
-   * Creates the JSON serialized form of the accessory for use over the Homekit Accessory Protocol.
+   * Creates the JSON serialized form of the accessory for use over the HomeKit Accessory Protocol.
    *
    * @param instanceId the static id of the accessory.
    * @return a future that will complete with the JSON builder for the object.
@@ -92,7 +92,7 @@ protected CompletableFuture<JsonObjectBuilder> makeBuilder(int instanceId) {
     return futureValue
         .exceptionally(
             t -> {
-              logger.error("Could not retrieve value " + this.getClass().getName(), t);
+              logger.warn("Could not retrieve value " + this.getClass().getName(), t);
               return null;
             })
         .thenApply(
@@ -126,7 +126,7 @@ public final void setValue(JsonValue jsonValue) {
     try {
       setValue(convert(jsonValue));
     } catch (Exception e) {
-      logger.error("Error while setting JSON value", e);
+      logger.warn("Error while setting JSON value", e);
     }
   }
 
@@ -136,7 +136,7 @@ public void supplyValue(JsonObjectBuilder builder) {
     try {
       setJsonValue(builder, getValue().get());
     } catch (InterruptedException | ExecutionException e) {
-      logger.error("Error retrieving value", e);
+      logger.warn("Error retrieving value", e);
       setJsonValue(builder, getDefault());
     }
   }

src/main/java/io/github/hapjava/characteristics/impl/base/EnumCharacteristic.java

@@ -14,7 +14,7 @@
 
 /**
  * Characteristic that exposes an Enum value. Enums are represented as an Integer value in the
- * Homekit protocol, and classes extending this one must handle the static mapping to an Integer
+ * HomeKit protocol, and classes extending this one must handle the static mapping to an Integer
  * value.
  *
  * @author Andy Lintner

src/main/java/io/github/hapjava/characteristics/package-info.java

@@ -1,4 +1,4 @@
 /**
- * Contains the basic characteristic types that can be supplied over the Homekit Accessory Protocol.
+ * Contains the basic characteristic types that can be supplied over the HomeKit Accessory Protocol.
  */
 package io.github.hapjava.characteristics;

src/main/java/io/github/hapjava/server/HomekitAuthInfo.java

@@ -22,7 +22,7 @@ public interface HomekitAuthInfo {
   String getPin();
 
   /**
-   * A unique MAC address to be advertised with the Homekit information. This does not have to be
+   * A unique MAC address to be advertised with the HomeKit information. This does not have to be
    * the MAC address of the network interface. You can generate this using {@link
    * HomekitServer#generateMac()}.
    *

src/main/java/io/github/hapjava/server/impl/HomekitRegistry.java

@@ -37,7 +37,7 @@ public synchronized void reset() {
         newServices.add(new AccessoryInformationService(accessory));
         newServices.addAll(accessory.getServices());
       } catch (Exception e) {
-        logger.error("Could not instantiate services for accessory " + accessory.getName(), e);
+        logger.warn("Could not instantiate services for accessory " + accessory.getName(), e);
         services.put(accessory, Collections.emptyList());
         continue;
       }

src/main/java/io/github/hapjava/server/impl/HomekitRoot.java

@@ -13,8 +13,8 @@
 import org.slf4j.LoggerFactory;
 
 /**
- * Provides advertising and handling for Homekit accessories. This class handles the advertising of
- * Homekit accessories and contains one or more accessories. When implementing a bridge accessory,
+ * Provides advertising and handling for HomeKit accessories. This class handles the advertising of
+ * HomeKit accessories and contains one or more accessories. When implementing a bridge accessory,
  * you will interact with this class directly. Instantiate it via {@link
  * HomekitServer#createBridge(HomekitAuthInfo, String, String, String, String, String, String)}. For
  * single accessories, this is composed by {@link HomekitStandaloneAccessoryServer}.
@@ -54,7 +54,7 @@ public class HomekitRoot {
   }
 
   /**
-   * Add an accessory to be handled and advertised by this root. Any existing Homekit connections
+   * Add an accessory to be handled and advertised by this root. Any existing HomeKit connections
    * will be terminated to allow the clients to reconnect and see the updated accessory list. When
    * using this for a bridge, the ID of the accessory must be greater than 1, as that ID is reserved
    * for the Bridge itself.
@@ -77,33 +77,33 @@ public void addAccessory(HomekitAccessory accessory) {
    */
   void addAccessorySkipRangeCheck(HomekitAccessory accessory) {
     this.registry.add(accessory);
-    logger.info("Added accessory " + accessory.getName());
+    logger.trace("Added accessory " + accessory.getName());
     if (started) {
       registry.reset();
       webHandler.resetConnections();
     }
   }
 
   /**
-   * Removes an accessory from being handled or advertised by this root. Any existing Homekit
+   * Removes an accessory from being handled or advertised by this root. Any existing HomeKit
    * connections will be terminated to allow the clients to reconnect and see the updated accessory
    * list.
    *
    * @param accessory accessory to cease advertising and handling
    */
   public void removeAccessory(HomekitAccessory accessory) {
     this.registry.remove(accessory);
-    logger.info("Removed accessory " + accessory.getName());
+    logger.trace("Removed accessory " + accessory.getName());
     if (started) {
       registry.reset();
       webHandler.resetConnections();
     }
   }
 
   /**
-   * Starts advertising and handling the previously added Homekit accessories. You should try to
+   * Starts advertising and handling the previously added HomeKit accessories. You should try to
    * call this after you have used the {@link #addAccessory(HomekitAccessory)} method to add all the
-   * initial accessories you plan on advertising, as any later additions will cause the Homekit
+   * initial accessories you plan on advertising, as any later additions will cause the HomeKit
    * clients to reconnect.
    */
   public void start() {
@@ -123,7 +123,7 @@ public void start() {
             });
   }
 
-  /** Stops advertising and handling the Homekit accessories. */
+  /** Stops advertising and handling the HomeKit accessories. */
   public void stop() {
     advertiser.stop();
     webHandler.stop();

src/main/java/io/github/hapjava/server/impl/HomekitServer.java

@@ -10,7 +10,7 @@
 import java.util.concurrent.ExecutionException;
 
 /**
- * The main entry point for hap-java. Creating an instance of this class will listen for Homekit
+ * The main entry point for hap-java. Creating an instance of this class will listen for HomeKit
  * connections on the supplied port. Only a single root accessory can be added for each unique
  * instance and port, however, that accessory may be a {@link #createBridge(HomekitAuthInfo, String,
  * String, String, String, String, String) bridge accessory} containing child accessories.
@@ -19,7 +19,7 @@
  * implementation supplied by your application. Several of the values needed for your implementation
  * are provided by this class, specifically {@link #generateKey() generateKey}, {@link
  * #generateMac() generateMac}, and {@link #generateSalt()}. It is important that you provide these
- * same values on each start of your application or Homekit will fail to recognize your device as
+ * same values on each start of your application or HomeKit will fail to recognize your device as
  * being the same.
  *
  * @author Andy Lintner
@@ -160,7 +160,7 @@ public static String generateMac() {
 
   /**
    * Generates a value to supply in {@link HomekitAuthInfo#getPin() HomekitAuthInfo.getPin()}. This
-   * is used as the Pin a user enters into their Homekit device in order to confirm pairing.
+   * is used as the Pin a user enters into their HomeKit device in order to confirm pairing.
    *
    * @return the generated Pin
    */

src/main/java/io/github/hapjava/server/impl/HomekitStandaloneAccessoryServer.java

@@ -9,7 +9,7 @@
 import java.util.concurrent.ExecutionException;
 
 /**
- * A server for exposing standalone Homekit accessory (as opposed to a Bridge accessory which
+ * A server for exposing standalone HomeKit accessory (as opposed to a Bridge accessory which
  * contains multiple accessories). Each standalone accessory will have its own pairing information,
  * port, and pin. Instantiate this class via {@link
  * HomekitServer#createStandaloneAccessory(HomekitAuthInfo, HomekitAccessory)}.