Skip to content

Commit 5a58bfa

Browse files
[#119] added support for valid values for target HumidifierDehumidifierState
1 parent 2aa7769 commit 5a58bfa

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

src/main/java/io/github/hapjava/accessories/HumidifierDehumidifierAccessory.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,16 @@ public interface HumidifierDehumidifierAccessory extends HomekitAccessory {
5757
CompletableFuture<Void> setTargetHumidifierDehumidifierState(
5858
TargetHumidifierDehumidifierStateEnum state);
5959

60+
/**
61+
* Valid values for target state.
62+
*
63+
* @return array of valid target states.
64+
*/
65+
default TargetHumidifierDehumidifierStateEnum[]
66+
getTargetHumidifierDehumidifierStateValidValues() {
67+
return TargetHumidifierDehumidifierStateEnum.values();
68+
}
69+
6070
/**
6171
* Subscribes to changes in the humidifier/dehumidifier current state.
6272
*

src/main/java/io/github/hapjava/characteristics/impl/humidifier/TargetHumidifierDehumidifierStateCharacteristic.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@ public class TargetHumidifierDehumidifierStateCharacteristic
1515
implements EventableCharacteristic {
1616

1717
public TargetHumidifierDehumidifierStateCharacteristic(
18+
TargetHumidifierDehumidifierStateEnum[] validValues,
1819
Supplier<CompletableFuture<TargetHumidifierDehumidifierStateEnum>> getter,
1920
ExceptionalConsumer<TargetHumidifierDehumidifierStateEnum> setter,
2021
Consumer<HomekitCharacteristicChangeCallback> subscriber,
2122
Runnable unsubscriber) {
2223
super(
2324
"000000B4-0000-1000-8000-0026BB765291",
2425
"target humidifier state",
25-
TargetHumidifierDehumidifierStateEnum.values(),
26+
validValues,
2627
Optional.of(getter),
2728
Optional.of(setter),
2829
Optional.of(subscriber),

src/main/java/io/github/hapjava/services/impl/HumidifierDehumidifierService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public HumidifierDehumidifierService(HumidifierDehumidifierAccessory accessory)
5454
accessory::subscribeCurrentHumidifierDehumidifierState,
5555
accessory::unsubscribeCurrentHumidifierDehumidifierState),
5656
new TargetHumidifierDehumidifierStateCharacteristic(
57+
accessory.getTargetHumidifierDehumidifierStateValidValues(),
5758
accessory::getTargetHumidifierDehumidifierState,
5859
accessory::setTargetHumidifierDehumidifierState,
5960
accessory::subscribeTargetHumidifierDehumidifierState,

0 commit comments

Comments
 (0)