I can start a TestProcess("docker-compose", "up") but how to stop it?

[alanwilter]

@pytest.fixture(scope="session")
def app_server():
    with TestProcess("docker-compose", "up") as app_server:
        wait_for_strings(app_server.read, 60, "Booting worker")
        print(app_server.read())
        yield app_server
        print("\n>>>>Teardown app_service")

This is doing fine, but the teardown is not happening (docker ps shows my apps still running)

I added this line app_server.close("docker-compose stop") in a desperate guess, for no avail.

Would you have a suggestion on how act here?

[ionelmc]

The TestProcess class doesn't have any method close that takes arbitrary shell script, how would that work?

Problem there that docker-compose's behavior is inconsistent from a signaling point of view. Sometimes it shuts down the service, sometimes it kills it, sometimes it simply just detaches from the output.

Eg:

• send SIGTERM once to well behaved service - clean service shutdown
• send SIGTERM once to bad behaved service (process 1 inside the container doesn't respond to sigterm or whatever you have set as shutdown signal for the service) - service isn't getting shut down, and TestProcess will SIGKILL the docker-compose process before it get to to the hard shutdown (something like docker-compose kill)
• send SIGTERM twice to bad behaved service - service it getting killed (but TestProces doesn't do that)

I guess this would have 2 solutions:

• make TestProcess have some customization options wrt how process shutdown is done (eg: bigger timeout)
• you fix your service to be well behaved, eg: read on https://blog.ionelmc.ro/2016/05/07/dealing-with-docker/#process-handling or anything on the "pid 1 problem"