3.0.0: pytest is failing in one unit

[kloczek]

3.0.0 + #5
and pytest is failing

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-process-tests-3.0.0-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-process-tests-3.0.0-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra -m 'not network' --exit-0-if-no-units
============================= test session starts ==============================
platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/tkloczko/rpmbuild/BUILD/python-process-tests-3.0.0
configfile: pytest.ini
testpaths: tests
collected 3 items

tests/test_process_tests.py ..F                                          [100%]

=================================== FAILURES ===================================
_________________________________ test_socket __________________________________
tests/test_process_tests.py:36: in test_socket
    wait_for_strings(proc.read, TIMEOUT, 'Serving HTTP on')
../../BUILDROOT/python-process-tests-3.0.0-2.fc35.x86_64/usr/lib/python3.8/site-packages/process_tests.py:246: in wait_for_strings
    raise AssertionError(f'Waited {seconds:0.2f}secs but {check_strings} did not appear in output in the given order !')
E   AssertionError: Waited 60.00secs but ['Serving HTTP on'] did not appear in output in the given order !
----------------------------- Captured stdout call -----------------------------
********************************************** SERVER **********************************************

****************************************************************************************************
=========================== short test summary info ============================
FAILED tests/test_process_tests.py::test_socket - AssertionError: Waited 60.0...
==================== 1 failed, 2 passed in 61.65s (0:01:01) ====================
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57/test_safe_get_no_perms0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_safe_get_no_perms0'
  warnings.warn(
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57/test_safe_set_no_perms0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_safe_set_no_perms0'
  warnings.warn(
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57/test_safe_delete_no_perms0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_safe_delete_no_perms0'
  warnings.warn(
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57/test_rmtree_errorhandler_reado0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_rmtree_errorhandler_reado0'
  warnings.warn(
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57/test_rmtree_errorhandler_rerai0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_rmtree_errorhandler_rerai0'
  warnings.warn(
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:95: PytestWarning: (rm_rf) error removing /tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57
<class 'OSError'>: [Errno 39] Directory not empty: '/tmp/pytest-of-tkloczko/garbage-8b7a16b5-3c9f-40c8-aa6e-b7863d30de57'
  warnings.warn(

[tornaria]

Try this:

--- a/tests/test_process_tests.py	2023-11-01 14:34:11.000000000 -0300
+++ b/tests/test_process_tests.py	2023-12-05 19:18:06.663214341 -0300
@@ -30,7 +30,7 @@
 
 
 def test_socket():
-    with TestProcess('python', '-mhttp.server', '0') as proc:
+    with TestProcess('python', '-u', '-mhttp.server', '0') as proc:
         with dump_on_error(proc.read, 'SERVER'):
             wait_for_strings(proc.read, TIMEOUT, 'Serving HTTP on')
             (port,) = re.match(r'Serving HTTP on .*? port (\d+) ', proc.read()).groups()

[kloczek]

-    with TestProcess('python', '-mhttp.server', '0') as proc:
+    with TestProcess('python', '-u', '-mhttp.server', '0') as proc:

Nowhere in the code python or any other hardcodes executable name should be used.
sys.executable should be used .. only.

[tornaria]

Nowhere in the code python or any other hardcodes executable name should be used. sys.executable should be used .. only.

Irrelevant for the issue in hand. Either adding -u fixes the issue for you, or it does not. I don't care if your binary is named perl or ruby.

[kloczek]

Irrelevant for the issue in hand. Either adding -u fixes the issue for you, or it does not. I don't care if your binary is named perl or ruby.

It is relevant .. I have no binary python in build env.

[tornaria]

Irrelevant for the issue in hand. Either adding -u fixes the issue for you, or it does not. I don't care if your binary is named perl or ruby.

It is relevant .. I have no binary python in build env.

But you know how to and already fixed that, didn't you? Just add -u on top of #5, try running pytest, and report back. If it works, feel free to make a PR for this issue on top of #5.

[ionelmc]

You could also set the PYTHONUNBUFFERED=yes env var (like I set it in tox.ini).