Coal Expanded (Continued) + This mod makes pawns unable to refuel

[MrFastZombie]

Using Mlie's version of Coal Expanded with this causes an issue where pawns are unable to refuel.

In the mod settings, coal is marked as an invalid item.

I tried having coal expanded load both before and after Burn it For Fuel, but it doesn't seem to change anything.

I also tried having charcoal and coal in a stockpile in addition to wood but the same issue occurs.

I also found this issue with floor torches, wall torches, passive cooler, and the fueled smithy. I suspect it happens with anything that uses the Burn it For Fuel 2 fuel tab. The coal powered workstations included in Coal Expanded (Continued) are unaffected.

Upon right-clicking an affected thing, the option to refuel will be there but will be greyed out due to missing ingredients, despite having wood available, which is enabled in the fuel tab.

The modlist I used to test this is as follows:

• jikulopo.prepatcher
• brrainz.harmony
• ilyvion.LoadingProgress
• Revolus.NoDds
• aleksey.betterstacktraces
• Ludeon.RimWorld
• Ludeon.RimWorld.Royalty
• Ludeon.RimWorld.Ideology
• Ludeon.RimWorld.Biotech
• Ludeon.RimWorld.Anomaly
• Ludeon.RimWorld.Odyssey
• JPT.BurnItForFuel
• Mlie.CoalExpanded
• Dubwise.DubsPerformanceAnalyzer.steam
• Taranchuk.PerformanceOptimizer

(I also tested without prepatcher and performance optimizer just to make sure)

Stack trace from opening the fuel tab on a campfire, without performance optimizer, prepatcher, or loading progress:

[BurnItForFuel] Invalid base fuel assigned to Campfire.
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.UnityEngine.StackTraceUtility.ExtractStackTrace_Patch1()
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Log.Error_Patch2(System.String)
[[JPT] Burn It for Fuel 2, BurnItForFuel.dll] BurnItForFuel.CompSelectFuel.EquivalentFuelRatio(Verse.ThingDef def)
[[JPT] Burn It for Fuel 2, BurnItForFuel.dll] BurnItForFuel.HarmonyPatches.LabelLeft_Prefix(Verse.Listing_TreeThingFilter __instance, System.Single& widthOffset)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Listing_Tree.LabelLeft_Patch1(Verse.Listing_Tree, System.String, System.String, System.Int32, System.Single, System.Nullable`1[UnityEngine.Color], System.Single)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Listing_TreeThingFilter.DoThingDef_Patch1(Verse.Listing_TreeThingFilter, Verse.ThingDef, System.Int32, Verse.Map)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Listing_TreeThingFilter.DoCategoryChildren_Patch1(Verse.Listing_TreeThingFilter, Verse.TreeNode_ThingCategory, System.Int32, System.Int32, Verse.Map, System.Boolean)
[Core, Assembly-CSharp.dll] Verse.Listing_TreeThingFilter.ListCategoryChildren(Verse.TreeNode_ThingCategory node, System.Int32 openMask, Verse.Map map, UnityEngine.Rect visibleRect)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.ThingFilterUI.DoThingFilterConfigWindow_Patch1(UnityEngine.Rect, Verse.ThingFilterUI+UIState, Verse.ThingFilter, Verse.ThingFilter, System.Int32, System.Collections.Generic.IEnumerable`1[Verse.ThingDef], System.Collections.Generic.IEnumerable`1[Verse.SpecialThingFilterDef], System.Boolean, System.Boolean, System.Boolean, System.Collections.Generic.List`1[Verse.ThingDef], Verse.Map)
[Core, Assembly-CSharp.dll] RimWorld.ITab_Storage.FillTab()
[Core, Assembly-CSharp.dll] Verse.InspectTabBase+<>c__DisplayClass19_0.<DoTabGUI>b__0()
[Core, Assembly-CSharp.dll] Verse.ImmediateWindow.DoWindowContents(UnityEngine.Rect inRect)
[Core, Assembly-CSharp.dll] Verse.Window.InnerWindowOnGUI(System.Int32 x)
[System, UnityEngine.IMGUIModule.dll] UnityEngine.GUI.CallWindowDelegate(UnityEngine.GUI+WindowFunction func, System.Int32 id, System.Int32 instanceID, UnityEngine.GUISkin _skin, System.Int32 forceRect, System.Single width, System.Single height, UnityEngine.GUIStyle style)

[MrFastZombie]

After looking at the XML for coal, I noticed it does not have a flammability value. Patching both charcoal and coal to be flammable makes it valid and fixes the issue. I think this is something for Mlie to fix in the Coal Expanded mod. I'll keep this issue open until that's resolved in case you want to keep track of it or add a patch if Mlie decides not to update Coal Expanded for whatever reason.

Here's my personal temporary patch in case anyone else come across this before it's resolved:

<?xml version="1.0" encoding="utf-8"?>
<Patch>
	<Operation Class="PatchOperationAdd">
		<xpath>/Defs/ThingDef[defName = "Coal"]/statBases</xpath>
		<value>
			<Flammability>1.5</Flammability>
			<MaxHitPoints>150</MaxHitPoints>
		</value>
	</Operation>
	<Operation Class="PatchOperationAdd">
		<xpath>/Defs/ThingDef[defName = "Charcoal"]/statBases</xpath>
		<value>
			<Flammability>1.5</Flammability>
			<MaxHitPoints>150</MaxHitPoints>
		</value>
	</Operation>
	<Operation Class="PatchOperationAdd">
		<xpath>/Defs/ThingDef[defName = "Coal"]</xpath>
		<value>
			<useHitPoints>true</useHitPoints>
		</value>
	</Operation>
	<Operation Class="PatchOperationAdd">
		<xpath>/Defs/ThingDef[defName = "Charcoal"]</xpath>
		<value>
			<useHitPoints>true</useHitPoints>
		</value>
	</Operation>
</Patch>

I'm not sure yet what the the flammability should be. This results in 112% fuel value. I haven't tested if this is a balanced value. The log complains about hitpoints, but defining <MaxHitPoints> didn't work and I don't know how to enable it properly, so this would probably cause coal to burn indefinitely. I have since found out how to enable hitpoints on thingdefs, I've updated the patch above to reflect that.

EDIT: For the sake keeping track, here's the link to the related bug report on Mlie's discord server https://discord.com/channels/680705672911913016/1456773969276567787

[jptrrs]

I'm glad you found a workaround. You could also have disabled taking flammability into consideration from the fuel calculation options (though that would disable it for every other resource as well). So, this isn't really an issue on our end, more like an edge case for compatibility... But I'm leaving this up for now so other people can copy your patch as needed. Thanks for that!
I'm not sure if I encountered that "hitpoints" complaint when testing this mod against other coal mods during development, so you might be onto something new. If you want me to take a look, please open a separate issue and I'll see if I can help. Please, this time include all the info I need! It's all explained here:https://github.com/jptrrs/BurnItForFuel/wiki

EDIT: wrong link to reporting an issue.

[MrFastZombie]

As an update: Mlie has responded to the bug report. They said that flammability of coal/charcoal should be patched by mods that require it.

I tested disabling the flammability setting and that does let pawns refuel things again.

As for the hitpoints, I don't think that's an issue with this mod in particular. I just included that as something to take into consideration as an issue with my patch as it was before I figured out how to enable hitpoints, it's a vanilla quirk as far as I can tell. The other coal mods that do have flammability defined by default probably also already enabled hitpoints.

Since I didn't include it before, here's the hugslib log after reproducing the issue. (I turned off flammability in the calc at the end)
https://gist.github.com/HugsLibRecordKeeper/da877d78916a3b27e4fb611c587c38da

I do think that there may be something to look into here, maybe fuels considered invalid should automatically be removed from the default fuel lists of refuellable things provided that they would not be empty after doing so? It wouldn't fix coal not being usable with both calculation settings enabled but it would hopefully still let pawns refuel things. If you want me to open another issue for that let me know and I'll do so.