From 506465619a6d6266d3068470ed39871c302ff19b Mon Sep 17 00:00:00 2001 From: "Chris Nolan.ca" Date: Thu, 5 Sep 2024 11:52:25 -0400 Subject: [PATCH 01/28] Fallback to 'receivedByName' if Fedex's 'signedByName' is missing when tracking the 'signed_by' info --- .../fedex/karrio/providers/fedex/tracking.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/connectors/fedex/karrio/providers/fedex/tracking.py b/modules/connectors/fedex/karrio/providers/fedex/tracking.py index d0feead6a6..1c33674978 100644 --- a/modules/connectors/fedex/karrio/providers/fedex/tracking.py +++ b/modules/connectors/fedex/karrio/providers/fedex/tracking.py @@ -121,10 +121,16 @@ def _extract_details( shipment_origin_country=lib.failsafe( lambda: detail.originLocation.locationContactAndAddress.address.countryCode ), - signed_by=lib.failsafe(lambda: detail.deliveryDetails.signedByName), + signed_by=lib.failsafe( + lambda: ( + detail.deliveryDetails.signedByName + if detail.deliveryDetails.signedByName + else (detail.deliveryDetails.receivedByName) + ) + ), ), images=lib.identity(models.Images(signature_image=img) if img else None), - estimated_delivery=lib.fdate(estimated_delivery, "%Y-%m-%dT%H:%M:%S"), + estimated_delivery=lib.fdate(estimated_delivery, try_formats=DATETIME_FORMATS), delivered=(status == "delivered"), status=status, ) From 2248e6dcd1f490d7b14023975183e75c017bf9bf Mon Sep 17 00:00:00 2001 From: "Chris Nolan.ca" Date: Thu, 5 Sep 2024 12:04:01 -0400 Subject: [PATCH 02/28] Update my tracking re estimated delivery dates to try and avoid merge conflicts --- .../connectors/fedex/karrio/providers/fedex/tracking.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/connectors/fedex/karrio/providers/fedex/tracking.py b/modules/connectors/fedex/karrio/providers/fedex/tracking.py index 1c33674978..4dc08ad9f6 100644 --- a/modules/connectors/fedex/karrio/providers/fedex/tracking.py +++ b/modules/connectors/fedex/karrio/providers/fedex/tracking.py @@ -53,9 +53,10 @@ def _extract_details( default=None, ) estimated_delivery = lib.failsafe( - lambda: ( + lambda: lib.fdate( detail.standardTransitTimeWindow.window.begins - or detail.estimatedDeliveryTimeWindow.window.begins + or detail.estimatedDeliveryTimeWindow.window.begins, + try_formats=DATETIME_FORMATS, ) ) status = next( @@ -130,7 +131,7 @@ def _extract_details( ), ), images=lib.identity(models.Images(signature_image=img) if img else None), - estimated_delivery=lib.fdate(estimated_delivery, try_formats=DATETIME_FORMATS), + estimated_delivery=estimated_delivery=estimated_delivery, delivered=(status == "delivered"), status=status, ) From aedfc93d640f41be2e5b2079e0dd06c5e278d300 Mon Sep 17 00:00:00 2001 From: "Chris Nolan.ca" Date: Thu, 5 Sep 2024 12:28:42 -0400 Subject: [PATCH 03/28] Trying to prevent merge conflicts --- .../connectors/fedex/karrio/providers/fedex/tracking.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/connectors/fedex/karrio/providers/fedex/tracking.py b/modules/connectors/fedex/karrio/providers/fedex/tracking.py index 1c33674978..2ccb76aa27 100644 --- a/modules/connectors/fedex/karrio/providers/fedex/tracking.py +++ b/modules/connectors/fedex/karrio/providers/fedex/tracking.py @@ -53,9 +53,10 @@ def _extract_details( default=None, ) estimated_delivery = lib.failsafe( - lambda: ( + lambda: lib.fdate( detail.standardTransitTimeWindow.window.begins - or detail.estimatedDeliveryTimeWindow.window.begins + or detail.estimatedDeliveryTimeWindow.window.begins, + try_formats=DATETIME_FORMATS, ) ) status = next( @@ -130,7 +131,7 @@ def _extract_details( ), ), images=lib.identity(models.Images(signature_image=img) if img else None), - estimated_delivery=lib.fdate(estimated_delivery, try_formats=DATETIME_FORMATS), + estimated_delivery=estimated_delivery, delivered=(status == "delivered"), status=status, ) From 8b28f8bdde06510cd3453b4b78020b70d30ca49f Mon Sep 17 00:00:00 2001 From: "Chris Nolan.ca" Date: Wed, 18 Sep 2024 10:06:15 -0400 Subject: [PATCH 04/28] Correct typo "Delet" -> "Delete" and add tracking number to the dialog --- apps/dashboard/src/modules/Trackers/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/dashboard/src/modules/Trackers/index.tsx b/apps/dashboard/src/modules/Trackers/index.tsx index 263d8e9cfe..27e2ab1b36 100644 --- a/apps/dashboard/src/modules/Trackers/index.tsx +++ b/apps/dashboard/src/modules/Trackers/index.tsx @@ -142,7 +142,7 @@ export default function TrackersPage(pageProps: any) { + + {/* Conditionally render additional info */} + {isExpanded && ( +
+ {Object.entries(tracker.info || {}) + .filter(([_, value]) => value != null) // Exclude null or undefined values + .map(([key, value], index) => ( +
+ {prettifyKey(key)}: {" "} + {customRender(key, value)} +
+ ))} +
+ )} )}