diff --git a/CHANGELOG.md b/CHANGELOG.md index 15571cf144e..caaf1b3de4b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ - [[PR575]](https://github.com/lanl/singularity-eos/pull/575) Pin variant submodule to the same commit as the spackage ### Infrastructure (changes irrelevant to downstream codes) +- [[PR594]](https://github.com/lanl/singularity-eos/pull/594) clean up tests in preparation for ports-of-call variant transition - [[PR588]](https://github.com/lanl/singularity-eos/pull/588) Add DensityEnergyFromPressureTemperature in unit system test - [[PR576]](https://github.com/lanl/singularity-eos/pull/576) Clean up some header includes to use the C++ versions - [[PR559]](https://github.com/lanl/singularity-eos/pull/559) Document the intent of the virtual keyword in solvers diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index dce185feed2..c7f1a7da17e 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -121,11 +121,19 @@ if(SINGULARITY_BUILD_CLOSURE) catch_discover_tests(closure_unit_tests PROPERTIES TIMEOUT 120) if(SINGULARITY_USE_SPINER) - add_executable(test_pte test_pte.cpp) - target_link_libraries(test_pte PRIVATE Catch2::Catch2 - singularity-eos::singularity-eos) - target_include_directories(test_pte PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}) - add_test(pte test_pte) + if(SINGULARITY_USE_KOKKOS AND Kokkos_ENABLE_HIP + AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "19.0.0") + message(WARNING + "Test PTE appears to encounter a compiler bug for LLVM builds targeting AMD GPUs " + "for compiler versions ${CMAKE_CXX_COMPILER_VERSION} < 19, and the test is disabled. " + "Note this corresponds to rocm versions less than 6.4.") + else() + add_executable(test_pte test_pte.cpp) + target_link_libraries(test_pte PRIVATE Catch2::Catch2 + singularity-eos::singularity-eos) + target_include_directories(test_pte PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}) + add_test(pte test_pte) + endif() add_executable(test_pte_2phase test_pte_2phaseVinetSn.cpp) target_link_libraries(test_pte_2phase PRIVATE Catch2::Catch2 diff --git a/test/test_pte.cpp b/test/test_pte.cpp index 007458e092d..bee30f1adbb 100644 --- a/test/test_pte.cpp +++ b/test/test_pte.cpp @@ -47,8 +47,8 @@ using atomic_view = Kokkos::MemoryTraits; #endif template