-
Notifications
You must be signed in to change notification settings - Fork 0
Few Suggestions & Issues #1
Description
A few Suggestions:
-
Button to close out the welcome to linky public beta.
1.1.The popup is pretty annoying and maybe not everyone think it is but I do and I'd rather have a way to opt-out of it being there. Although I probably not access the Panel much as after you set it up you really don't have to.
make beta announcement dismissable 063fa2e -
Button to reset your API key just in case you leaked it and some people know it
(not sure what you can do with it at the moment but I assume you can just link accounts and or spam send requests).
2.1. Basically just so you can reset it so people don't do stuff with your API key. -
When a user is offline and they get link requests a few of them should be saved for when they come back online to be sent to the user.
3.1. The only use for this is if someone can not at all have discord and Minecraft open at the same time although rare would still be nice for them users and they can still link to get rewards or something in their favorite server. -
A viewable list on the panel of all linked accounts and A way to search for A Minecraft username, discord username.
4.1. The only use I can think of is if someone did something bad in your discord server and you want to check if they are linked to ban them from in-game as well. -
Don't hardcode the API url in the plugin
5.1. This may be A bad idea as people may not know what it is change it and blame this as not working but A way to sort fix this even though it probably wont if people dont read is to include A comment next to it like:
token: "x" # The API key from the web panel https://linky.astrid.sh/
api_url: "https://linky.astrid.sh/api" # This is the API url DO NOT change it unless you know what your doing.-
Proxy Support
6.1. Might not be needed as I think you can use the same API key for all servers and putting the plugin on the proxy will mean you probably can't do anything with skript but possibly support for BungeeCord/Waterfall and Velocity in the future? -
A /unlink command
7.1.I saw that there wasn't A /unlink command there probably should be tbh.
add unlink endpoint f43e752
A few issues:
- /link command
8.1. It has A issue where providing invalid parameters it will throw A error in console it might be A issue in commando or in the plugin for linky but I dont know. It could also be because I ran it in console just as/link?
[21:27:08 WARN]: Unexpected exception while parsing console command "link"
org.bukkit.command.CommandException: Unhandled exception executing command 'link' in plugin Linky v1.0-SNAPSHOT
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_19_R3.CraftServer.dispatchCommand(CraftServer.java:906) ~[paper-1.19.4.jar:git-Paper-522]
at org.bukkit.craftbukkit.v1_19_R3.CraftServer.dispatchServerCommand(CraftServer.java:869) ~[paper-1.19.4.jar:git-Paper-522]
at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:501) ~[paper-1.19.4.jar:git-Paper-522]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:448) ~[paper-1.19.4.jar:git-Paper-522]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1397) ~[paper-1.19.4.jar:git-Paper-522]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1174) ~[paper-1.19.4.jar:git-Paper-522]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[paper-1.19.4.jar:git-Paper-522]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalArgumentException: argument type mismatch
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at me.honkling.commando.CommandManager.registerCommands$lambda$5(CommandManager.kt:108) ~[Linky.jar:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
... 9 more- Cache
API.getUser
9.1. Right now for me atleast it takes A little bit for the response of your API so it probably should be cached and it should eventually expire so that if you relink it does change (although right now you can't unlink atleast I think I don't know if running /link in discord again does anything if you do it on a different account) Tbh this is kinda A issue and A suggestion.
Also sorry for writing such A long issue xd.