Skip to content

Remove command is case-sensitive to folder names #22

@m-triassi

Description

@m-triassi

Description

Files dont get deleted when attemting to deleted them if their case doesn't match the name of the downloaded zip

Expected Behavior

The Regex that searches for the appropriate file should find the folder to delete, regardless of casing, and delete it.

Current Behavior

When folders match the casing of their corresponding zip file, they are deleted as expected. When they do not match the same casing the folder remains in place.

Reproduction Steps

  1. Attempt to add an addon with casing which is mismatched from the extracted file (eg: OmniCD: 306489)
  2. Run the command to remove this addon
  3. Observe that the folder "OmniCD" has not been deleted, as it's case differs from the API returned named "omnicd"

Possible Implementation

The regex which searches for the associated file should be case insensitive, or it the data structure used to store which addons are installed can be made more complex and could store the install path, removing the need for a Regex

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions