-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
Fluent UI react (v8)Issues about @fluentui/react (v8)Issues about @fluentui/react (v8)Needs: Triage 🔍Type: Bug 🐛
Description
Package
react
Package version
8.115.6
React version
17.0.2
Environment
Didn't work. Issue is also on fluent ui webpage:
https://developer.microsoft.com/en-us/fluentui#/controls/web/textfield:~:text=Password%20with%20reveal%20buttonCurrent Behavior
- Contrast issues and visibility issues in Desert, Aquatic and Dark themes.
- Not accessible through keyboard actions or voice command to enable/disable the show/hidden features through eye icon button
- When focus is lost on textfield component, the icon disappears and can't show/hide the text anymore besides by erasing the whole password and then the option shows itself again when clean.
3: (See that icon is no longer present in 'after' picture)
Before -
After -
Expected Behavior
The eye icon should maintain accessibility standards to solve all of the issues above.
- The icon should be visible and have good contrast in all supported themes.
- The icon should be accessible through keyboard and voice commands.
- The icon shouldn't disappear when losing focus on the textfield component
Reproduction
Steps to reproduce
-
Go to link.
-
Enable dark/aquatic/desert mode themes and see that button isn't visible in at least 1 of the 2 modes.
-
Go to link.
-
Try to access the eye icon through keyboard or voice command and see it isn't possible.
-
Go to link.
-
Enter password.
-
Focus on other element in page.
-
Return focus to element and see that eye icon has disappeared.
Are you reporting an Accessibility issue?
yes
Suggested severity
Urgent - No workaround and Products/sites are affected
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
Metadata
Metadata
Assignees
Labels
Fluent UI react (v8)Issues about @fluentui/react (v8)Issues about @fluentui/react (v8)Needs: Triage 🔍Type: Bug 🐛
