Impossible to extend the ctest suite with a new test

[amurgZainar]

I tried extending the test suite with an additional test following these instructions: https://github.com/microsoft/jbpf/blob/main/jbpf_tests/README.md.

The new test that I've added is not compiled as part of the jbpf library build process when building the jbpf library in the Docker container. Also, what I notice is that, even though that the tests from the existing test suite are compiled (as seen in the build process output), the executables are not stored anywhere when the build finishes, so can I can manually execute the test cases (for examples the executables under jbpf_tests/verifier, those are, jbpf_basic_verifier_test and jbpf_verifier_extension_test.

NOTE that this is not happening when the jbpf library is built locally (not in Docker). When building it locally, the test suite can be extended and the executables for each tests are being stored under their corresponding directory.

So questions:

1. How can I alter the existing test suite to take into account the new added tests when building the library inside the Docker?
2. How can I make the existing build process with Docker to store the test suite executables that it's already building?
3. Locally/with Docker how can I rebuild just the test suite?

[doctorlai-msrc]

Hi,

1. You need to alter the CMakeLists under the tests folder to add your new tests
2. You need to map the /jbpf/build directory e.g. docker run -v pwd/build:/jbpf/build as the tests are stored in /jbpf/build directory
3. You would need to make test locally or docker run --rm --entrypoint make jbpf /jbpf/build test

[amurgZainar]

1. I followed the two steps described in the documentation https://github.com/microsoft/jbpf/blob/main/jbpf_tests/README.md

Step1:

Create a New Folder: In the appropriate directory (e.g., unit_tests, functional, e2e_examples), create a new folder for your test set.
Add CMakeLists.txt: Create a CMakeLists.txt file in your new folder. Here's a template:
set(JBPF_TESTS ${JBPF_TESTS} PARENT_SCOPE)
set(A_NEW_TEST a_new_test)
set(A_NEW_TEST_SOURCE a_new_test.c ${TESTS_COMMON}/jbpf_test_lib.c)
add_executable(${A_NEW_TEST} ${A_NEW_TEST_SOURCE})
target_link_libraries(${A_NEW_TEST} PUBLIC ${JBPF_LIB})
target_include_directories(${A_NEW_TEST} PUBLIC ${HEADER_FILES} ${TEST_HEADER_FILES})
add_test(NAME ${A_NEW_TEST} COMMAND ${A_NEW_TEST})
list(APPEND JBPF_TESTS ${A_NEW_TEST})
set(JBPF_TESTS ${JBPF_TESTS} PARENT_SCOPE)
add_clang_format_check(${A_NEW_TEST} ${A_NEW_TEST_SOURCE})
add_cppcheck(${A_NEW_TEST} ${A_NEW_TEST_SOURCE})
Update Parent CMakeLists.txt: In the parent directory's CMakeLists.txt, add a reference to your new test directory:

Step 2:

add_subdirectory(a_new_test)

docker run -v /build:/jbpf/build Is your command correct? I assumed the you mean the following command: sudo -E docker run -v $DEST_PATH:/jbpf_out_lib -v $DEST_PATH/build:/jbpf_out_lib/build jbpf_lib, but even with this command, nothing gets stored to the build directory as you said. Also, my new test is not even taken into account. Can you please check the command locally?

• make test runs the ctest suite only if was built locally apriori.
• docker run --rm --entrypoint make jbpf /jbpf/build test runs the ctest suite but in Docker after the build process ends.

I don't understand whether the docker run --rm --entrypoint make jbpf /jbpf/build test should be a followup of the command from point 2., which is not having the desired outcome.

[doctorlai-msrc]

First, make sure your new test is run locally. You can do this:

1. mkdir build && cd build
2. cmake ../
3. make -j
4. make test

If your test is not shown, it is likely that your test is not included in CMakeLists.txt.

[amurgZainar]

Hello,

Steps 1-3 seems to be working fine. When executed locally, the test that I've added is being built. Step 4, make test seems to get stuck indefinitely at test #2:

~/dev/repos/jbpf_fork/build$ make test
Running tests...
Test project /home/alex/dev/repos/jbpf_fork/build
        Start   1: jbpf_e2e_standalone_test
  1/117 Test   #1: jbpf_e2e_standalone_test ...........................................Subprocess aborted***Exception:   0.59 sec
        Start   2: jbpf_e2e_ipc_test


^Cmake: *** [Makefile:71: test] Interrupt
        

Although, steps 4. doesn't get stuck if the make test is run from build/jbpf_tests.

[doctorlai-msrc]

Try sudo -E make test if it gets stuck