TypeError: Cannot read properties of undefined (reading 'mtime') on some CI runs

[sjwilczynski]

Describe the bug
In microsoft/nova-facade#149 we bumped lage from 2.7.15 to 2.14.0. Since then we have noticed couple of failures on CI runs with the following error:

/mnt/vss/_work/1/s/node_modules/lage/dist/lage.js:415
`),"utf-8")}hash(e){let r={},n=[],i=(0,Ppe.stat)(e,{cwd:this.options.root})??{};for(let o of e){let a=i[o],c=$h(this,PE)[o];c&&a.mtime===c.mtime&&a.size==c.size?r[o]=c.hash:n.push(o)}let s=(0,Ppe.hash)(n,{cwd:this.options.root,concurrency:4})??{};for(let[o,a]of Object.entries(s)){let c=vN.default.statSync(GL.default.join(this.options.root,o),{bigint:!0});$h(this,PE)[o]={mtime:c.mtimeMs,size:Number(c.size),hash:a??""},r[o]=a??""}return r}constructor(e){m_r(this,"options",void 0),cit(this,PE,{writable:!0,value:void 0}),cit(this,b_,{writable:!0,value:void 0}),this.options=e,lit(this,PE,{});let{root:r}=e,n=GL.default.join(r,"node_modules",".cache","lage");lit(this,b_,GL.default.join(n,"file_hashes.manifest"))}}});var WL=A(ru=>{"use strict";ru.isInteger=t=>typeof t=="number"?Number.isInteger(t):typeof t=="string"&&t.trim()!==""?Number.isInteger(Number(t)):!1;ru.find=(t,e)=>t.nodes.find(r=>r.type===e);ru.exceedsLimit=(t,e,r=1,n)=>n===!1||!ru.isInteger(t)||!ru.isInteger(e)?!1:(Number(e)-Number(t))/Number(r)>=n;ru.escapeNode=(t,e=0,r)=>{let n=t.nodes[e];n&&(r&&n.type===r||n.type==="open"||n.type==="close")&&n.escaped!==!0&&(n.value="\\"+n.value,n.escaped=!0)};ru.encloseBrace=t=>t.type!=="brace"||t.commas>>0+t.ranges>>0?!1:(t.invalid=!0,!0);ru.isInvalidBrace=t=>t.type!=="brace"?!1:t.invalid===!0||t.dollar?!0:!(t.commas>>0+t.ranges>>0)||t.open!==!0||t.close!==!0?(t.invalid=!0,!0):!1;ru.isOpenOrClose=t=>t.type==="open"||t.type==="close"?!0:t.open===!0||t.close===!0;ru.reduce=t=>t.reduce((e,r)=>(r.type==="text"&&e.push(r.value),r.type==="range"&&(r.type="text"),e),[]);ru.flatten=(...t)=>{let e=[],r=n=>{for(let i=0;i<n.length;i++){let s=n[i];if(Array.isArray(s)){r(s);continue}s!==void 0&&e.push(s)}return e};return r(t),e}});var JL=A((t9n,fit)=>{"use strict";var pit=WL();fit.exports=(t,e={})=>{let r=(n,i={})=>{let s=e.escapeInvalid&&pit.isInvalidBrace(i),o=n.invalid===!0&&e.escapeInvalid===!0,a="";if(n.value)return(s||o)&&pit.isOpenOrClose(n)?"\\"+n.value:n.value;if(n.value)return n.value;if(n.nodes)for(let c of n.nodes)a+=r(c);return a};return r(t)}});var Mpe=A((r9n,vit)=>{"use strict";var A_r=require("util"),mit=kG(),hit=t=>t!==null&&typeof t=="object"&&!Array.isArray(t),g_r=t=>e=>t===!0?Number(e):String(e),Dpe=t=>typeof t=="number"||typeof t=="string"&&t!=="",CN=t=>Number.isInteger(+t),Qpe=t=>{let e=`${t}`,r=-1;if(e[0]==="-"&&(e=e.slice(1)),e==="0")return!1;for(;e[++r]==="0";);return r>0},y_r=(t,e,r)=>typeof t=="string"||typeof e=="string"?!0:r.stringify===!0,E_r=(t,e,r)=>{if(e>0){let n=t[0]==="-"?"-":"";n&&(t=t.slice(1)),t=n+t.padStart(n?e-1:e,"0")}return r===!1?String(t):t},XL=(t,e)=>{let r=t[0]==="-"?"-":"";for(r&&(t=t.slice(1),e--);t.length<e;)t="0"+t;return r?"-"+t:t},v_r=(t,e,r)=>{t.negatives.sort((a,c)=>a<c?-1:a>c?1:0),t.positives.sort((a,c)=>a<c?-1:a>c?1:0);let n=e.capture?"":"?:",i="",s="",o;return t.positives.length&&(i=t.positives.map(a=>XL(String(a),r)).join("|")),t.negatives.length&&(s=`-(${n}${t.negatives.map(a=>XL(String(a),r)).join("|")})`),i&&s?o=`${i}|${s}`:o=i||s,e.wrap?`(${n}${o})`:o},Ait=(t,e,r,n)=>{if(r)return mit(t,e,{wrap:!1,...n});let i=String.fromCharCode(t);if(t===e)return i;let s=String.fromCharCode(e);return`[${i}-${s}]`},git=(t,e,r)=>{if(Array.isArray(t)){let n=r.wrap===!0,i=r.capture?"":"?:";return n?`(${i}${t.join("|")})`:t.join("|")}return mit(t,e,r)},yit=(...t)=>new RangeError("Invalid range arguments: "+A_r.inspect(...t)),Eit=(t,e,r)=>{if(r.strictRanges===!0)throw yit([t,e]);return[]},C_r=(t,e)=>{if(e.strictRanges===!0)throw new TypeError(`Expected step "${t}" to be a number`);return[]},b_r=(t,e,r=1,n={})=>{let i=Number(t),s=Number(e);if(!Number.isInteger(i)||!Number.isInteger(s)){if(n.strictRanges===!0)throw yit([t,e]);return[]}i===0&&(i=0),s===0&&(s=0);let o=i>s,a=String(t),c=String(e),l=String(r);r=Math.max(Math.abs(r),1);let u=Qpe(a)||Qpe(c)||Qpe(l),d=u?Math.max(a.length,c.length,l.length):0,p=u===!1&&y_r(t,e,n)===!1,f=n.transform||g_r(p);if(n.toRegex&&r===1)return Ait(XL(t,d),XL(e,d),!0,n);let h={negatives:[],positives:[]},m=b=>h[b<0?"negatives":"positives"].push(Math.abs(b)),E=[],C=0;for(;o?i>=s:i<=s;)n.toRegex===!0&&r>1?m(i):E.push(E_r(f(i,C),d,p)),i=o?i-r:i+r,C++;return n.toRegex===!0?r>1?v_r(h,n,d):git(E,null,{wrap:!1,...n}):E},w_r=(t,e,r=1,n={})=>{if(!CN(t)&&t.length>1||!CN(e)&&e.length>1)return Eit(t,e,n);let i=n.transform||(p=>String.fromCharCode(p)),s=`${t}`.charCodeAt(0),o=`${e}`.charCodeAt(0),a=s>o,c=Math.min(s,o),l=Math.max(s,o);if(n.toRegex&&r===1)return Ait(c,l,!1,n);let u=[],d=0;for(;a?s>=o:s<=o;)u.push(i(s,d)),s=a?s-r:s+r,d++;return n.toRegex===!0?git(u,null,{wrap:!1,options:n}):u},KL=(t,e,r,n={})=>{if(e==null&&Dpe(t))return[t];if(!Dpe(t)||!Dpe(e))return Eit(t,e,n);if(typeof r=="function")return KL(t,e,1,{transform:r});if(hit(r))return KL(t,e,0,r);let i={...n};return i.capture===!0&&(i.wrap=!0),r=r||i.step||1,CN(r)?CN(t)&&CN(e)?b_r(t,e,r,i):w_r(t,e,Math.max(Math.abs(r),1),i):r!=null&&!hit(r)?C_r(r,i):KL(t,e,1,r)};vit.exports=KL});var wit=A((n9n,bit)=>{"use strict";var __r=Mpe(),Cit=WL(),I_r=(t,e={})=>{let r=(n,i={})=>{let s=Cit.isInvalidBrace(i),o=n.invalid===!0&&e.escapeInvalid===!0,a=s===!0||o===!0,c=e.escapeInvalid===!0?"\\":"",l="";if(n.isOpen===!0)return c+n.value;if(n.isClose===!0)return console.log("node.isClose",c,n.value),c+n.value;if(n.type==="open")return a?c+n.value:"(";if(n.type==="close")return a?c+n.value:")";if(n.type==="comma")return n.prev.type==="comma"?"":a?n.value:"|";if(n.value)return n.value;if(n.nodes&&n.ranges>0){let u=Cit.reduce(n.nodes),d=__r(...u,{...e,wrap:!1,toRegex:!0,strictZeros:!0});if(d.length!==0)return u.length>1&&d.length>1?`(${d})`:d}if(n.nodes)for(let u of n.nodes)l+=r(u,n);return l};return r(t)};bit.exports=I_r});var Sit=A((i9n,Iit)=>{"use strict";var S_r=Mpe(),_it=JL(),w_=WL(),OE=(t="",e="",r=!1)=>{let n=[];if(t=[].concat(t),e=[].concat(e),!e.length)return t;if(!t.length)return r?w_.flatten(e).map(i=>`{${i}}`):e;for(let i of t)if(Array.isArray(i))for(let s of i)n.push(OE(s,e,r));else for(let s of e)r===!0&&typeof s=="string"&&(s=`{${s}}`),n.push(Array.isArray(s)?OE(i,s,r):i+s);return w_.flatten(n)},T_r=(t,e={})=>{let r=e.rangeLimit===void 0?1e3:e.rangeLimit,n=(i,s={})=>{i.queue=[];let o=s,a=s.queue;for(;o.type!=="brace"&&o.type!=="root"&&o.parent;)o=o.parent,a=o.queue;if(i.invalid||i.dollar){a.push(OE(a.pop(),_it(i,e)));return}if(i.type==="brace"&&i.invalid!==!0&&i.nodes.length===2){a.push(OE(a.pop(),["{}"]));return}if(i.nodes&&i.ranges>0){let d=w_.reduce(i.nodes);if(w_.exceedsLimit(...d,e.step,r))throw new RangeError("expanded array length exceeds range limit. Use options.rangeLimit to increase or disable the limit.");let p=S_r(...d,e);p.length===0&&(p=_it(i,e)),a.push(OE(a.pop(),p)),i.nodes=[];return}let c=w_.encloseBrace(i),l=i.queue,u=i;for(;u.type!=="brace"&&u.type!=="root"&&u.parent;)u=u.parent,l=u.queue;for(let d=0;d<i.nodes.length;d++){let p=i.nodes[d];if(p.type==="comma"&&i.type==="brace"){d===1&&l.push(""),l.push("");continue}if(p.type==="close"){a.push(OE(a.pop(),l,c));continue}if(p.value&&p.type!=="open"){l.push(OE(l.pop(),p.value));continue}p.nodes&&n(p,i)}return l};return w_.flatten(n(t))};Iit.exports=T_r});var Rit=A((s9n,Tit)=>{"use strict";Tit.exports={MAX_LENGTH:1e4,CHAR_0:"0",CHAR_9:"9",CHAR_UPPERCASE_A:"A",CHAR_LOWERCASE_A:"a",CHAR_UPPERCASE_Z:"Z",CHAR_LOWERCASE_Z:"z",CHAR_LEFT_PARENTHESES:"(",CHAR_RIGHT_PARENTHESES:")",CHAR_ASTERISK:"*",CHAR_AMPERSAND:"&",CHAR_AT:"@",CHAR_BACKSLASH:"\\",CHAR_BACKTICK:"`",CHAR_CARRIAGE_RETURN:"\r",CHAR_CIRCUMFLEX_ACCENT:"^",CHAR_COLON:":",CHAR_COMMA:",",CHAR_DOLLAR:"$",CHAR_DOT:".",CHAR_DOUBLE_QUOTE:'"',CHAR_EQUAL:"=",CHAR_EXCLAMATION_MARK:"!",CHAR_FORM_FEED:"\f",CHAR_FORWARD_SLASH:"/",CHAR_HASH:"#",CHAR_HYPHEN_MINUS:"-",CHAR_LEFT_ANGLE_BRACKET:"<",CHAR_LEFT_CURLY_BRACE:"{",CHAR_LEFT_SQUARE_BRACKET:"[",CHAR_LINE_FEED:`
                                                                                                                                 ^
 
TypeError: Cannot read properties of undefined (reading 'mtime')
    at Ope.hash (/mnt/vss/_work/1/s/node_modules/lage/dist/lage.js:415:130)
    at Jpe.hash (/mnt/vss/_work/1/s/node_modules/lage/dist/lage.js:416:12759)
    at see.u (/mnt/vss/_work/1/s/node_modules/lage/dist/lage.js:407:870)
    at see.emit (node:events:517:28)
    at Worker.l (/mnt/vss/_work/1/s/node_modules/lage/dist/lage.js:299:5090)
    at Worker.emit (node:events:517:28)
    at MessagePort.<anonymous> (node:internal/worker:256:53)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:786:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

Unfortunately, these failures don't happen every time, they seem to happen a bit randomly.

To Reproduce
I wasn't able to reproduce locally or even on PR pipeline but if you go to facade repo, you can inspect recent release runs.

Expected behavior
Lage works fine or indicates more clearly if there is some configuration issue.

[sjwilczynski]

Seems to be fixed by microsoft/nova-facade#154 but I am still a bit confused why. Anyway closing for now

[dobesv]

Possible fix here: #907

I'm not holding my breath that the fix will ever be merged, though.