From d2d9d90ecb284f03102ab5782e6d12f8213c5ddf Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Sun, 16 Mar 2025 20:01:10 -0700 Subject: [PATCH 1/3] Show target.id in error about missing inputs I got this error and had no idea what target it was complaining about. --- packages/hasher/src/TargetHasher.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hasher/src/TargetHasher.ts b/packages/hasher/src/TargetHasher.ts index cb3f6b7f0..dd7341bbf 100644 --- a/packages/hasher/src/TargetHasher.ts +++ b/packages/hasher/src/TargetHasher.ts @@ -170,7 +170,7 @@ export class TargetHasher { if (target.cwd === root && target.cache) { if (!target.inputs) { - throw new Error("Root-level targets must have `inputs` defined if it has cache enabled."); + throw new Error(`Missing inputs on target ${target.id}; cannot cache.`); } const files = await globAsync(target.inputs, { cwd: root }); From a38b73f313ab5bebcd77f43c8ddcea22603395b1 Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Fri, 18 Apr 2025 21:08:08 -0700 Subject: [PATCH 2/3] Tweak message --- packages/hasher/src/TargetHasher.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hasher/src/TargetHasher.ts b/packages/hasher/src/TargetHasher.ts index dd7341bbf..eb9b87408 100644 --- a/packages/hasher/src/TargetHasher.ts +++ b/packages/hasher/src/TargetHasher.ts @@ -170,7 +170,7 @@ export class TargetHasher { if (target.cwd === root && target.cache) { if (!target.inputs) { - throw new Error(`Missing inputs on target ${target.id}; cannot cache.`); + throw new Error(`No "inputs" specified for target "${target.id}"; cannot cache.`); } const files = await globAsync(target.inputs, { cwd: root }); From f2f516db4a3afc667abb02572d60005552534022 Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Fri, 18 Apr 2025 21:08:38 -0700 Subject: [PATCH 3/3] Change files --- .../change-b0cbf202-cf01-4765-8abe-769d88057f43.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 change/change-b0cbf202-cf01-4765-8abe-769d88057f43.json diff --git a/change/change-b0cbf202-cf01-4765-8abe-769d88057f43.json b/change/change-b0cbf202-cf01-4765-8abe-769d88057f43.json new file mode 100644 index 000000000..50a2c0026 --- /dev/null +++ b/change/change-b0cbf202-cf01-4765-8abe-769d88057f43.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "type": "patch", + "comment": "Show target.id in error about missing inputs", + "packageName": "@lage-run/hasher", + "email": "dobes@formative.com", + "dependentChangeType": "patch" + } + ] +} \ No newline at end of file