From 1e0a77c16409dce62d4c5d0e4355d7bbe703e8f6 Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Sat, 29 Mar 2025 13:25:30 -0700 Subject: [PATCH 1/2] If target has no outputs set, and no global outputGlob set, assume no outputs Assuming that every file in the target directory is an output to be cached doesn't seem correct here - if they didn't specify outputs, assume there are none instead. --- packages/cache/src/providers/BackfillCacheProvider.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cache/src/providers/BackfillCacheProvider.ts b/packages/cache/src/providers/BackfillCacheProvider.ts index d1b75f0f0..8776983c9 100644 --- a/packages/cache/src/providers/BackfillCacheProvider.ts +++ b/packages/cache/src/providers/BackfillCacheProvider.ts @@ -76,7 +76,7 @@ export class BackfillCacheProvider implements CacheProvider { const cacheStorage = this.getTargetCacheStorageProvider(target.cwd, hash); try { - await cacheStorage.put(hash, target.outputs ?? this.options.cacheOptions.outputGlob ?? ["**/*"]); + await cacheStorage.put(hash, target.outputs ?? this.options.cacheOptions.outputGlob ?? []); } catch (error) { let message; From 72f3c63ada4b89324b6ee4f61e17e22be44743ef Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Fri, 18 Apr 2025 21:21:59 -0700 Subject: [PATCH 2/2] Change files --- .../change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 change/change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json diff --git a/change/change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json b/change/change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json new file mode 100644 index 000000000..ec6c3b41c --- /dev/null +++ b/change/change-50d5ec94-8c4b-470b-be07-7bebaea6503f.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "type": "patch", + "comment": "If target has no outputs set, and no global outputGlob set, assume no outputs", + "packageName": "@lage-run/cache", + "email": "dobes@formative.com", + "dependentChangeType": "patch" + } + ] +} \ No newline at end of file