Variable ETFeederNode::num_ops_ can have uninitialized value

[przemekbary]

Describe the Bug

The variable ETFeederNode::num_ops_ can have uninitialized value, as it might not be initialized in the constructor. This can lead to random behavior in Workload::issue() function (see condition checking here https://github.com/astra-sim/astra-sim/blame/master/astra-sim/workload/Workload.cc#L138)

Steps to Reproduce

Use any chakra file that has no num_ops field

Expected Behavior

The field num_ops_ should be initialized to default value of 0

Screenshots

[przemekbary]

PR available here to fix the issue:
#204

[jinsun-yoo]

Thank you for raising this issue! In a recent, unrelated PR the condition has been removed & refactored. However, this does remain an important issue.

After the PR, the link (pointing to the newest master branch) is now 'outdated'. For recording purpose, the link pointing to the conditional statement is follows: https://github.com/astra-sim/astra-sim/blame/ee852f49d4f1f382219981a60b439f96e34b9113/astra-sim/workload/Workload.cc#L132

[jinsun-yoo]

It looks like these values also need to be initialized in the constructor to prevent similar corruption. Therefore, I will leave this issue open.

uint32_t tensor_loc_;
uint64_t tensor_size_;
ChakraProtoMsg::CollectiveCommType comm_type_;
uint32_t comm_priority_;
uint64_t comm_size_;
uint32_t comm_src_;
uint32_t comm_dst_;
uint32_t comm_tag_;