Skip to content

Combine unable to pull IPs from threat feed that have comments  #165

@redlot10

Description

@redlot10

I noticed Combine is unable to pull IPs from threat feeds which start with #.

For example: When I supply the following URL in either the inbound_url.txt or outbound_ur.txt, I do not get any output in harvest.csv:

https://raw.githubusercontent.com/firehol/blocklist-ipsets/master/bds_atif.ipset

But when I provide the following URL which does not have any comments at the beginning of the IP feed, Combine is able to pull the IP list correctly:

http://malc0de.com/bl/IP_Blacklist.txt

Could you please update the code where if Combine sees # or a space at the beginning of the line, it should be able to just go to the next line and then start pulling out the relevant data (IPs, etc.)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions