Skip to content

Additional comments for #290 #293

@dzeber

Description

@dzeber

@alberginia Is there a reason for keeping the Queue managed outside of the SyntheticDataStreamer? I feel like this is an implementation detail that should be encapsulated inside the streamer class. The queue could be a member variable of the SyntheticDataStreamer class, set up automatically when the streamer instance is created. Then SyntheticDataStreamer could have a get() method which gets an item from the queue. The streamer instance would then be passed to the ContinuousCopy class rather than the queue. What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions