Skip to content

[code review] "Hide changeset" is broken with Review Helper installed #5504

@theres-waldo

Description

@theres-waldo

Steps to reproduce

  1. View a Phabricator revision with Review Helper installed
  2. Click "View Options" next to the name of one of the files in the diff
  3. Select "Hide changeset"

Expected results

The diff for that file is collapsed.

Actual results

No change to the page.

Devtools console shows:

Uncaught Error: JX.DOM.find(<node>, "div", "differential-inline-comment"): matched no nodes.
    $E https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:2
    find https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:361
    bindToRow https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:197
    _newInlineForRow https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:386
    getInlineForRow https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:385
    getSelectableItems https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:359
    _getSelectableItems https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:536
    selectChangeset https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:524
    select https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:431
    visible_item https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/603acc6f/differential.pkg.js:557
    _onclick https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:735
    pass https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:164
    _dispatchProxy https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:159
    dispatch https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/994b5954/core.pkg.js:142
    __rawEventQueue https://mozphab-phabhost-cdn.devsvcprod.mozaws.net/res/defaultX/phabricator/98e6504a/rsrc/externals/javelin/core/init.js:19

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions