From 732f487ab807af19f1b7d1e7164f5d9ed445c735 Mon Sep 17 00:00:00 2001 From: Leon Mak Date: Mon, 26 Mar 2018 18:51:40 -0700 Subject: [PATCH 1/2] Fix cannot delete regions --- src/plugins/regions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/regions.js b/src/plugins/regions.js index 771f186..655cbb7 100644 --- a/src/plugins/regions.js +++ b/src/plugins/regions.js @@ -58,7 +58,7 @@ class Regions extends Component { } // cache reference to old regions - const oldRegions = Object.create(this.props.wavesurfer.regions.list); + const oldRegions = Object.assign({}, this.props.wavesurfer.regions.list); let newRegionId; let oldRegionId; From 5082f1c5ca451beb19e83848535732cd087ee9f4 Mon Sep 17 00:00:00 2001 From: Leon Mak Date: Tue, 27 Mar 2018 14:15:08 -0700 Subject: [PATCH 2/2] Update regions.js remove old region after updating --- src/plugins/regions.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/regions.js b/src/plugins/regions.js index 655cbb7..271cdbe 100644 --- a/src/plugins/regions.js +++ b/src/plugins/regions.js @@ -66,9 +66,6 @@ class Regions extends Component { if ({}.hasOwnProperty.call(nextProps.regions, newRegionId)) { const newRegion = nextProps.regions[newRegionId]; - // remove from oldRegions - delete oldRegions[newRegionId]; - // new regions if (!this.props.wavesurfer.regions.list[newRegionId]) { this._hookUpRegionEvents(nextProps.wavesurfer.addRegion(newRegion)); @@ -84,6 +81,9 @@ class Regions extends Component { end: newRegion.end }); } + + // remove from oldRegions + delete oldRegions[newRegionId]; } }