Skip to content

Name Tokens API: Refine "no tokens found" handling #1445

@lightwalker-eth

Description

@lightwalker-eth

It is wrong that no tokens found is a 404 error.

We must separate the following ideas:

  • We never indexed the name tokens associated with the given name / domainId, and therefore we have no knowledge about them at all. This is a valid 404 error.
  • We indexed the name tokens associated with the given name / domainId, but there were none. This is NOT a 404 error. It is a 200 response (OK) that should return an empty set of name tokens as no name tokens have ever been issued for the name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ensapiENSApi related

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions