Skip to content

NiSkinData complement #9

@neomonkeus

Description

@neomonkeus

Files require review

Allows access to the Bone-weights.

https://www.dropbox.com/s/s1xk3cq0y281o9w/NiSkinData.cpp.diff?dl=0
https://www.dropbox.com/s/od2qjuiesbz9707/NiSkinData.h.diff?dl=0

My feeling is that this patch goes against niflib's current design - it feels out of place. We have Get and Set functions for everything else elsewhere.
Could you rewrite it to fit that design?

(The other options is of course simply to make all data public... I'm actually not at all against that, but it would be a completely different library, and a lot of things would need to be readdressed.)

I can't really follow. It is a getter and a setter, and one that is in exactly the same way everywhere, just take GetVertices()/SetVertices(), it's almost a copy'n'paste job here only it's for bone-data. :^)

I don't actually care all that much, but:

  1. Your getter and setter are not symmetric (getter = bone data, setter = vector of weights).
  2. Your getter returns a raw pointer to the data; in other parts of the lib, a copy of the data is returned (IIRC).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions