forked from gup4win/wingup
-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Description
In the light of the recently found updater vulnerability in notepad++, I want to suggest to revisit the curl SSL options used by the updater.
E.g. https://github.com/notepad-plus-plus/wingup/blob/master/src/winmain.cpp#L1111 has:
curl_easy_setopt(curl, CURLOPT_SSL_OPTIONS, CURLSSLOPT_ALLOW_BEAST | CURLSSLOPT_NO_REVOKE);
I can't think of a good reason to set CURLSSLOPT_ALLOW_BEAST.
And CURLSSLOPT_REVOKE_BEST_EFFORT might be a better pick than CURLSSLOPT_NO_REVOKE
Metadata
Metadata
Assignees
Labels
No labels