Skip to content

revise curl SSL options #99

@jsinge

Description

@jsinge

In the light of the recently found updater vulnerability in notepad++, I want to suggest to revisit the curl SSL options used by the updater.

E.g. https://github.com/notepad-plus-plus/wingup/blob/master/src/winmain.cpp#L1111 has:

curl_easy_setopt(curl, CURLOPT_SSL_OPTIONS, CURLSSLOPT_ALLOW_BEAST | CURLSSLOPT_NO_REVOKE);

I can't think of a good reason to set CURLSSLOPT_ALLOW_BEAST.
And CURLSSLOPT_REVOKE_BEST_EFFORT might be a better pick than CURLSSLOPT_NO_REVOKE

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions