Edit option closeAfterEdit not functioning

[bchr02]

Edit option closeAfterEdit not functioning.

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {add: false, edit: true, del: false}, // navGrid options
    {closeAfterEdit: true}  // Edit options
);

However it does work when placed in

$.extend($.jgrid.edit, {closeAfterEdit: true}); 

[bouks]

Working good on my project.
In your example, closeAfterEdit is in add button options.

try

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {add: false, edit: true, del: false}, // navGrid options
    {},
    {closeAfterEdit: true}  // Edit options
);

[bouks]

Or

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {edit: true, add: false, del: false}, // navGrid options
    {closeAfterEdit: true}  // Edit options
);

[flack]

@bouks: I just looked at the function signature here:

jsgrid/js/grid.formedit.js

Line 1742 in 6c5783e

navGrid : function (elem, o, pEdit,pAdd,pDel,pSearch, pView) {

so edit options should be the third parameter

[flack]

sorry, just saw your second post after submitting ...

[bouks]

@flack I think to avoid this type of issue we should probably in a future version (2.0?) implement like this :

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {
        edit: {
            closeAfterEdit: true,
            afterSubmit:function(...){
                ...
            }
        },
        add: false,
        del: false
    }
);

or without options

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {
        edit: true,
        add: false,
        del: false
    }
);

[bouks]

Then, no matter the orders.

[flack]

@bouks: Yes, the API can definitely be improved. But to return to the original issue: Do I understand it correctly that the example from @bchr02 works on your machine?

[bouks]

@flack Yes.

[bouks]

But i do a different implementation of navgrid in my projects.
I do a function (that call navgrid with the parameters) and i call this function in gridComplete option.
What i remember is that i had problems with adding buttons in pager with conventionnal call.

[bchr02]

We should definitely improve the API. 👍 but in the meantime this appears to be a bug. It should be the third parameter, correct?

[bouks]

Are you using server side data ?
What is the return of the ajax call when you validate the form ?

[bouks]

If the return is a 300 code, or a 304 code (Not Modified), the closeAfterEdit won't happen.
Could you check this ?

[bchr02]

It looks something like this. { rowsAffected: undefined, outBinds: {}, rows: undefined }
and it's a 200 code

[bouks]

Excuse me i'm wrong. It will not close if code >= 300 AND code !== 304