From e2483ce88955cfcd099cbdcf6614779ed1413d51 Mon Sep 17 00:00:00 2001 From: Alessandro GIULIANI Date: Fri, 3 Sep 2021 10:41:06 +0200 Subject: [PATCH 1/3] [UPDATE] Symfony 5.x compat --- .gitignore | 1 + DependencyInjection/Configuration.php | 9 ++------- composer.json | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.gitignore b/.gitignore index 95f9096..85f75df 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ composer.lock /vendor/ phpunit.xml +.idea diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php index 9a0b613..b6fd49a 100644 --- a/DependencyInjection/Configuration.php +++ b/DependencyInjection/Configuration.php @@ -17,13 +17,8 @@ class Configuration implements ConfigurationInterface */ public function getConfigTreeBuilder() { - if (method_exists(TreeBuilder::class, 'getRootNode')) { - $treeBuilder = new TreeBuilder('opensoft_rollout'); - $rootNode = $treeBuilder->getRootNode(); - } else { - $treeBuilder = new TreeBuilder(); - $rootNode = $treeBuilder->root('opensoft_rollout'); - } + $treeBuilder = new TreeBuilder('opensoft_rollout'); + $rootNode = $treeBuilder->getRootNode(); // Here you should define the parameters that are allowed to // configure your bundle. See the documentation linked above for diff --git a/composer.json b/composer.json index df0a31c..f051d0d 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ ], "require": { "php": ">=5.3", - "symfony/framework-bundle": "~2.1|^3.0|^4.0", + "symfony/framework-bundle": "~2.1|^3.0|^4.0|^5.0", "opensoft/rollout": "~2.1" }, "require-dev": { From f72de956cf698fc691418bb90ceee77e7b87acd8 Mon Sep 17 00:00:00 2001 From: Alessandro GIULIANI Date: Fri, 3 Sep 2021 11:55:08 +0200 Subject: [PATCH 2/3] [FIX] PHP version + Twig functions --- Twig/Extension/RolloutExtension.php | 6 ++++-- composer.json | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Twig/Extension/RolloutExtension.php b/Twig/Extension/RolloutExtension.php index 1d8cf56..9f01803 100644 --- a/Twig/Extension/RolloutExtension.php +++ b/Twig/Extension/RolloutExtension.php @@ -4,11 +4,13 @@ use Opensoft\Rollout\RolloutUserInterface; use Opensoft\RolloutBundle\Rollout\GroupDefinitionAwareRollout; +use Twig\Extension\AbstractExtension; +use Twig\TwigFunction; /** * @author Richard Fullmer */ -class RolloutExtension extends \Twig_Extension +class RolloutExtension extends AbstractExtension { /** * @var GroupDefinitionAwareRollout @@ -31,7 +33,7 @@ public function __construct(GroupDefinitionAwareRollout $rollout) public function getFunctions() { return array( - new \Twig_SimpleFunction('rollout_is_active', function ($feature, RolloutUserInterface $user = null) { + new TwigFunction('rollout_is_active', function ($feature, RolloutUserInterface $user = null) { return $this->rollout->isActive($feature, $user); }) ); diff --git a/composer.json b/composer.json index f051d0d..4c8f438 100644 --- a/composer.json +++ b/composer.json @@ -9,7 +9,7 @@ } ], "require": { - "php": ">=5.3", + "php": ">=5.4", "symfony/framework-bundle": "~2.1|^3.0|^4.0|^5.0", "opensoft/rollout": "~2.1" }, From b2759cf9e3343611207966d865c8d7d939eed023 Mon Sep 17 00:00:00 2001 From: Alessandro GIULIANI Date: Fri, 24 Mar 2023 22:47:11 +0700 Subject: [PATCH 3/3] feat(composer): allow sf6 --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 4c8f438..507d87e 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "name": "opensoft/rollout-bundle", - "description": "A Symfony2/3/4 Bundle for opensoft/rollout", + "description": "A Symfony2/3/4/5/6 Bundle for opensoft/rollout", "license": "MIT", "authors": [ { @@ -10,7 +10,7 @@ ], "require": { "php": ">=5.4", - "symfony/framework-bundle": "~2.1|^3.0|^4.0|^5.0", + "symfony/framework-bundle": "~2.1|^3.0|^4.0|^5.0|^6.0", "opensoft/rollout": "~2.1" }, "require-dev": {