-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Custom gating model flag is independent of gating.model_name, so people can run custom gating models without the custom flag which at a minimum disrupts the wandb tagging.
- The custom flag should be triggered based on whether
gating.model_name == __DEFAULT_GATING_MODEL_NAME__or something similar. Resyncshould be pushed down to the base class as it's identical in both subclasses- Logic of creating
SentenceEmbedGatingModelvsGatingModelis also brittle. We default toGatingModelfor any othergating.model_nameif the custom flag is not set, which will almost certainly break with other models.
Metadata
Metadata
Assignees
Labels
No labels