Skip to content

Gating model config improvements #49

@steffencruz

Description

@steffencruz

Custom gating model flag is independent of gating.model_name, so people can run custom gating models without the custom flag which at a minimum disrupts the wandb tagging.

  • The custom flag should be triggered based on whether gating.model_name == __DEFAULT_GATING_MODEL_NAME__ or something similar.
  • Resync should be pushed down to the base class as it's identical in both subclasses
  • Logic of creating SentenceEmbedGatingModel vs GatingModel is also brittle. We default to GatingModel for any other gating.model_name if the custom flag is not set, which will almost certainly break with other models.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions