Skip to content

Commit 1173002

Browse files
Merge pull request #27 from optimizely/yasir/get-set-forcedvariation
feat: getForcedVariation and setForcedVariation API's implemented.
2 parents 108f811 + ff1a385 commit 1173002

File tree

10 files changed

+410
-360
lines changed

10 files changed

+410
-360
lines changed

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterClient.java

Lines changed: 181 additions & 177 deletions
Large diffs are not rendered by default.

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterSdkPlugin.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,14 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
5454
getVariation(argumentsParser, result);
5555
break;
5656
}
57+
case APIs.GET_FORCED_VARIATION: {
58+
getForcedVariation(argumentsParser, result);
59+
break;
60+
}
61+
case APIs.SET_FORCED_VARIATION: {
62+
setForcedVariation(argumentsParser, result);
63+
break;
64+
}
5765
case APIs.ADD_NOTIFICATION_LISTENER: {
5866
addNotificationListener(argumentsParser, result);
5967
break;

android/src/main/java/com/optimizely/optimizely_flutter_sdk/helper_classes/Constants.java

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ public static class APIs {
2020
public static final String CLOSE = "close";
2121
public static final String ACTIVATE = "activate";
2222
public static final String GET_VARIATION = "getVariation";
23+
public static final String GET_FORCED_VARIATION = "getForcedVariation";
24+
public static final String SET_FORCED_VARIATION = "setForcedVariation";
2325
public static final String INITIALIZE = "initialize";
2426
public static final String GET_OPTIMIZELY_CONFIG = "getOptimizelyConfig";
2527
public static final String CREATE_USER_CONTEXT = "createUserContext";
@@ -70,24 +72,11 @@ public static class RequestParameterKey {
7072

7173
public static class ErrorMessage {
7274
public static final String INVALID_PARAMS = "Invalid parameters provided.";
75+
public static final String INVALID_OPTIMIZELY_CLIENT = "Optimizely client is invalid.";
7376
public static final String OPTIMIZELY_CONFIG_NOT_FOUND = "No optimizely config found.";
7477
public static final String OPTIMIZELY_CLIENT_NOT_FOUND = "Optimizely client not found.";
7578
public static final String USER_CONTEXT_NOT_FOUND = "User context not found.";
76-
}
77-
78-
public static class SuccessMessage {
79-
public static final String INSTANCE_CREATED = "Optimizely instance created successfully.";
80-
public static final String OPTIMIZELY_CONFIG_FOUND = "Optimizely config found.";
81-
public static final String OPTIMIZELY_CLIENT_CLOSED = "Optimizely client closed successfully.";
82-
public static final String USER_CONTEXT_CREATED = "User context created successfully.";
83-
public static final String LISTENER_REMOVED = "Listener removed successfully.";
84-
public static final String DECIDE_CALLED = "Decide called successfully.";
85-
public static final String LISTENER_ADDED = "Listener added successfully.";
86-
public static final String ATTRIBUTES_ADDED = "Attributes added successfully.";
87-
public static final String EVENT_TRACKED = "Event Tracked successfully.";
88-
public static final String FORCED_DECISION_SET = "Forced decision set successfully.";
89-
public static final String REMOVED_FORCED_DECISION = "Forced decision removed successfully.";
90-
public static final String REMOVED_ALL_FORCED_DECISION = "All Forced decisions removed successfully.";
79+
public static final String USER_CONTEXT_NOT_CREATED = "User context not created.";
9180
}
9281

9382
public static class DecisionListenerKeys {

ios/Classes/HelperClasses/Constants.swift

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ struct API {
2121
static let getOptimizelyConfig = "getOptimizelyConfig"
2222
static let activate = "activate"
2323
static let getVariation = "getVariation"
24+
static let getForcedVariation = "getForcedVariation"
25+
static let setForcedVariation = "setForcedVariation"
2426
static let createUserContext = "createUserContext"
2527
static let getUserId = "getUserId"
2628
static let getAttributes = "getAttributes"
@@ -94,20 +96,6 @@ struct ErrorMessage {
9496
static let userContextNotFound = "User context not found."
9597
}
9698

97-
struct SuccessMessage {
98-
static let instanceCreated = "Optimizely instance created successfully."
99-
static let optimizelyConfigFound = "Optimizely config found."
100-
static let optimizelyClientClosed = "Optimizely client closed successfully."
101-
static let userContextCreated = "User context created successfully."
102-
static let attributesAdded = "Attributes added successfully."
103-
static let listenerAdded = "Listener added successfully."
104-
static let listenerRemoved = "Listener removed successfully."
105-
static let decideCalled = "Decide called successfully."
106-
static let forcedDecisionSet = "Forced decision set successfully."
107-
static let forcedDecisionRemoved = "Forced decision removed successfully."
108-
static let allForcedDecisionsRemoved = "All Forced decisions removed successfully."
109-
}
110-
11199
//Sohail: There is one issue, can we make sure the types remain same, probably we will need to write unit test separately for type.
112100
struct TypeValue {
113101
static let string = "string"

0 commit comments

Comments
 (0)