Skip to content

Commit 3c63d80

Browse files
committed
Refactored and using overloaded function to createResponse with just success status
1 parent a75567b commit 3c63d80

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterClient.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ protected void setForcedDecision(ArgumentsParser argumentsParser, @NonNull Resul
370370
return;
371371
}
372372

373-
result.success(createResponse(false, ""));
373+
result.success(createResponse(false));
374374
}
375375

376376
protected void getForcedDecision(ArgumentsParser argumentsParser, @NonNull Result result) {
@@ -397,7 +397,7 @@ protected void getForcedDecision(ArgumentsParser argumentsParser, @NonNull Resul
397397
result.success(createResponse(true, Collections.singletonMap(RequestParameterKey.VARIATION_KEY, forcedDecision.getVariationKey()), ""));
398398
}
399399

400-
result.success(createResponse(false, ""));
400+
result.success(createResponse(false));
401401
}
402402

403403
protected void removeForcedDecision(ArgumentsParser argumentsParser, @NonNull Result result) {
@@ -425,7 +425,7 @@ protected void removeForcedDecision(ArgumentsParser argumentsParser, @NonNull Re
425425
return;
426426
}
427427

428-
result.success(createResponse(false, ""));
428+
result.success(createResponse(false));
429429
}
430430

431431
protected void removeAllForcedDecisions(ArgumentsParser argumentsParser, @NonNull Result result) {
@@ -444,7 +444,7 @@ protected void removeAllForcedDecisions(ArgumentsParser argumentsParser, @NonNul
444444
result.success(createResponse(true, SuccessMessage.REMOVED_ALL_FORCED_DECISION));
445445
}
446446

447-
result.success(createResponse(false, ""));
447+
result.success(createResponse(false));
448448
}
449449

450450
protected void close(ArgumentsParser argumentsParser, @NonNull Result result) {
@@ -586,7 +586,7 @@ protected void getOptimizelyConfig(ArgumentsParser argumentsParser, @NonNull Res
586586
result.success(createResponse(true, optimizelyConfigMap, SuccessMessage.OPTIMIZELY_CONFIG_FOUND));
587587
}
588588

589-
public Map<String, ?> createResponse(Boolean success, Object result, String reason) {
589+
private Map<String, ?> createResponse(Boolean success, Object result, String reason) {
590590
Map<String, Object> response = new HashMap<>();
591591
response.put(ResponseKey.SUCCESS, success);
592592
response.put(ResponseKey.RESULT, result);
@@ -595,11 +595,11 @@ protected void getOptimizelyConfig(ArgumentsParser argumentsParser, @NonNull Res
595595
return response;
596596
}
597597

598-
public Map<String, ?> createResponse(Boolean success) {
598+
private Map<String, ?> createResponse(Boolean success) {
599599
return createResponse(success, null, "");
600600
}
601601

602-
public Map<String, ?> createResponse(Boolean success, String reason) {
602+
private Map<String, ?> createResponse(Boolean success, String reason) {
603603
return createResponse(success, null, reason);
604604
}
605605

0 commit comments

Comments
 (0)