Skip to content

Commit 684e626

Browse files
committed
Added unit tests to assert parameters received via channel.
1 parent f8be5ea commit 684e626

File tree

5 files changed

+158
-136
lines changed

5 files changed

+158
-136
lines changed

ios/Classes/HelperClasses/Constants.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ struct API {
2121
static let getOptimizelyConfig = "getOptimizelyConfig"
2222
static let activate = "activate"
2323
static let getVariation = "getVariation"
24-
static let setForcedVariation = "setForcedVariation"
25-
static let getForcedVariation = "getForcedVariation"
2624
static let createUserContext = "createUserContext"
2725
static let setAttributes = "setAttributes"
2826
static let trackEvent = "trackEvent"

ios/Classes/SwiftOptimizelyFlutterSdkPlugin.swift

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ public class SwiftOptimizelyFlutterSdkPlugin: NSObject, FlutterPlugin {
5353
case API.getOptimizelyConfig: getOptimizelyConfig(call, result: result)
5454
case API.activate: activate(call, result: result)
5555
case API.getVariation: getVariation(call, result: result)
56-
case API.setForcedVariation: setForcedVariation(call, result: result)
57-
case API.getForcedVariation: getForcedVariation(call, result: result)
5856
case API.createUserContext: createUserContext(call, result: result)
5957
case API.setAttributes: setAttributes(call, result: result)
6058
case API.trackEvent: trackEvent(call, result: result)
@@ -239,44 +237,6 @@ public class SwiftOptimizelyFlutterSdkPlugin: NSObject, FlutterPlugin {
239237
}
240238
}
241239

242-
/// Set forced variation for experiment and user ID to variationKey.
243-
///
244-
func setForcedVariation(_ call: FlutterMethodCall, result: @escaping FlutterResult) {
245-
guard let optimizelyClient = getOptimizelyClient(arguments: call.arguments) else {
246-
result(self.createResponse(success: false, reason: ErrorMessage.optlyClientNotFound))
247-
return
248-
}
249-
250-
guard let parameters = call.arguments as? Dictionary<String, Any?>, let experimentKey = parameters[RequestParameterKey.experimentKey] as? String, let userId = parameters[RequestParameterKey.userId] as? String else {
251-
result(createResponse(success: false, reason: ErrorMessage.invalidParameters))
252-
return
253-
}
254-
let variationKey = parameters[RequestParameterKey.variationKey] as? String
255-
let success = optimizelyClient.setForcedVariation(experimentKey: experimentKey, userId: userId, variationKey: variationKey)
256-
result(self.createResponse(success: success))
257-
}
258-
259-
/// Get forced variation for experiment and user ID.
260-
///
261-
func getForcedVariation(_ call: FlutterMethodCall, result: @escaping FlutterResult) {
262-
guard let optimizelyClient = getOptimizelyClient(arguments: call.arguments) else {
263-
result(self.createResponse(success: false, reason: ErrorMessage.optlyClientNotFound))
264-
return
265-
}
266-
267-
guard let parameters = call.arguments as? Dictionary<String, Any?>, let experimentKey = parameters[RequestParameterKey.experimentKey] as? String, let userId = parameters[RequestParameterKey.userId] as? String else {
268-
result(createResponse(success: false, reason: ErrorMessage.invalidParameters))
269-
return
270-
}
271-
if let variationKey = optimizelyClient.getForcedVariation(experimentKey: experimentKey, userId: userId) {
272-
result(self.createResponse(success: true, result: [RequestParameterKey.variationKey: variationKey]))
273-
return
274-
}
275-
result(self.createResponse(success: false))
276-
}
277-
278-
279-
280240
/// Creates a context of the user for which decision APIs will be called.
281241
/// A user context will only be created successfully when the SDK is fully configured using initializeClient.
282242
func createUserContext(_ call: FlutterMethodCall, result: @escaping FlutterResult) {

lib/optimizely_flutter_sdk.dart

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -93,20 +93,6 @@ class OptimizelyFlutterSdk {
9393
_sdkKey, experimentKey, userId, attributes);
9494
}
9595

96-
/// Get forced variation for experiment and user ID.
97-
Future<GetForcedDecisionResponse> getForcedVariation(
98-
String experimentKey, String userId) async {
99-
return await OptimizelyClientWrapper.getForcedVariation(
100-
_sdkKey, experimentKey, userId);
101-
}
102-
103-
/// Set forced variation for experiment and user ID to variationKey.
104-
Future<BaseResponse> setForcedVariation(String experimentKey, String userId,
105-
[String variationKey = ""]) async {
106-
return await OptimizelyClientWrapper.setForcedVariation(
107-
_sdkKey, experimentKey, userId, variationKey);
108-
}
109-
11096
/// Returns a snapshot of the current project configuration.
11197
Future<OptimizelyConfigResponse> getOptimizelyConfig() async {
11298
return await OptimizelyClientWrapper.getOptimizelyConfig(_sdkKey);

lib/src/optimizely_client_wrapper.dart

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -110,35 +110,6 @@ class OptimizelyClientWrapper {
110110
return GetForcedDecisionResponse(result);
111111
}
112112

113-
/// Get forced variation for experiment and user ID.
114-
static Future<GetForcedDecisionResponse> getForcedVariation(
115-
String sdkKey, String experimentKey, String userId) async {
116-
final result = Map<String, dynamic>.from(
117-
await _channel.invokeMethod(Constants.getForcedVariation, {
118-
Constants.sdkKey: sdkKey,
119-
Constants.experimentKey: experimentKey,
120-
Constants.userID: userId,
121-
}));
122-
return GetForcedDecisionResponse(result);
123-
}
124-
125-
/// Set forced variation for experiment and user ID to variationKey.
126-
static Future<BaseResponse> setForcedVariation(
127-
String sdkKey, String experimentKey, String userId,
128-
[String variationKey = ""]) async {
129-
Map<String, dynamic> request = {
130-
Constants.sdkKey: sdkKey,
131-
Constants.experimentKey: experimentKey,
132-
Constants.userID: userId,
133-
};
134-
if (variationKey != "") {
135-
request[Constants.variationKey] = variationKey;
136-
}
137-
final result = Map<String, dynamic>.from(
138-
await _channel.invokeMethod(Constants.setForcedVariation, request));
139-
return BaseResponse(result);
140-
}
141-
142113
/// Returns a snapshot of the current project configuration.
143114
static Future<OptimizelyConfigResponse> getOptimizelyConfig(
144115
String sdkKey) async {

0 commit comments

Comments
 (0)