Some more tests

Author: aliabbasrizvi

src/Optimizely/Optimizely.php

@@ -226,7 +226,7 @@ public function getVariation($experimentKey, $userId, $attributes = null)
     {
         $experiment = $this->_config->getExperimentFromKey($experimentKey);
 
-        if (!is_null($experiment->getKey())) {
+        if (is_null($experiment->getKey())) {
             return null;
         }
 

tests/OptimizelyTest.php

@@ -278,6 +278,32 @@ public function testActivateWithAttributes()
         $this->assertEquals('control', $optlyObject->activate('test_experiment', 'test_user', $userAttributes));
     }
 
+    public function testActivateExperimentNotRunning()
+    {
+        $this->eventBuilderMock->expects($this->never())
+            ->method('createImpressionEvent');
+
+        $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher());
+
+        $eventBuilder = new \ReflectionProperty(Optimizely::class, '_eventBuilder');
+        $eventBuilder->setAccessible(true);
+        $eventBuilder->setValue($optlyObject, $this->eventBuilderMock);
+
+        // Call activate
+        $this->assertNull($optlyObject->activate('paused_experiment', 'test_user', null));
+    }
+
+
+    public function testGetVariation()
+    {
+        $this->assertEquals('control', $this->optObj->getVariation('test_experiment', 'test_user'));
+    }
+
+    public function testGetVariationExperimentNotRunning()
+    {
+        $this->assertNull($this->optObj->getVariation('paused_experiment', 'test_user'));
+    }
+
     public function testTrackNoAttributesNoEventValue()
     {
         $this->eventBuilderMock->expects($this->once())

tests/ProjectConfigTest.php

@@ -202,7 +202,7 @@ public function testGetEventValidKey()
         $event = $this->config->getEvent('purchase');
         $this->assertEquals('purchase', $event->getKey());
         $this->assertEquals('7718020063', $event->getId());
-        $this->assertEquals(['7716830082', '7723330021', '7718750065'], $event->getExperimentIds());
+        $this->assertEquals(['7716830082', '7723330021', '7718750065', '7716830585'], $event->getExperimentIds());
     }
 
     public function testGetEventInvalidKey()

tests/TestData.php

@@ -36,7 +36,7 @@
     "variations": [{"id": "7713030086", "key": "group_exp_2_var_1"}, {"id": "7725250007", "key": "group_exp_2_var_2"}], "forcedVariations": {}, "id": "7718750065"}], "id": "7722400015"}], 
     "attributes": [{"id": "7723280020", "key": "device_type"}, {"id": "7723340004", "key": "location"}], 
     "projectId": "7720880029", "accountId": "1592310167", 
-    "events": [{"experimentIds": ["7716830082", "7723330021", "7718750065"], "id": "7718020063", "key": "purchase"}], 
+    "events": [{"experimentIds": ["7716830082", "7723330021", "7718750065", "7716830585"], "id": "7718020063", "key": "purchase"}], 
     "revision": "15"}');
 
 /**