Get rid of some technical debt

Author: ondrejmirtes

phpstan-baseline.neon

@@ -86,7 +86,7 @@ parameters:
 
 		-
 			message: "#^Doing instanceof PHPStan\\\\Type\\\\Constant\\\\ConstantStringType is error\\-prone and deprecated\\. Use Type\\:\\:getConstantStrings\\(\\) instead\\.$#"
-			count: 5
+			count: 2
 			path: src/Analyser/TypeSpecifier.php
 
 		-

src/Analyser/TypeSpecifier.php

@@ -369,7 +369,7 @@ public function specifyTypesInCondition(
 					&& $exprNode->name instanceof Name
 					&& strtolower($exprNode->name->toString()) === 'gettype'
 					&& isset($exprNode->getArgs()[0])
-					&& $constantType instanceof ConstantStringType
+					&& $constantType->isString()->yes()
 				) {
 					return $this->specifyTypesInCondition($scope, new Expr\BinaryOp\Identical($expr->left, $expr->right), $context, $rootExpr);
 				}
@@ -379,7 +379,7 @@ public function specifyTypesInCondition(
 					&& $exprNode->name instanceof Name
 					&& strtolower($exprNode->name->toString()) === 'get_class'
 					&& isset($exprNode->getArgs()[0])
-					&& $constantType instanceof ConstantStringType
+					&& $constantType->isString()->yes()
 				) {
 					return $this->specifyTypesInCondition($scope, new Expr\BinaryOp\Identical($expr->left, $expr->right), $context, $rootExpr);
 				}