Update for PHPStan 0.9

Author: lookyman

README.md

@@ -18,12 +18,13 @@ Put this into your `phpstan.neon` config:
 ```neon
 includes:
 	- vendor/lookyman/phpstan-symfony/extension.neon
-services:
-	- Lookyman\PHPStan\Symfony\ServiceMap(/path/to/appDevDebugProjectContainer.xml)
+parameters:
+	symfony:
+		srcDevDebugProjectContainerXml: %rootDir%/../../../var/cache/dev/srcDevDebugProjectContainer.xml
 ```
 
 ## Limitations
 
 It can only recognize pure strings passed into `ContainerInterface::get()` method. This follows from the nature of static code analysis.
 
-You have to provide a path to `appDevDebugProjectContainer.xml` or similar xml file describing your container. To generate it, you have to run the `Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::installAssets` composer script, which is part of Symfony's postinstall scripts. And to be able to run it, you have to have a database ready. Which kinda defeats the purpose of static code analysis, but whatever..
+You have to provide a path to `srcDevDebugProjectContainer.xml` or similar xml file describing your container.

composer.json

@@ -12,14 +12,15 @@
   ],
   "require": {
     "php": "^7.0",
-    "symfony/dependency-injection": "^3.2",
+    "symfony/dependency-injection": "^3.2|^4.0",
     "roave/security-advisories": "dev-master"
   },
   "require-dev": {
     "jakub-onderka/php-parallel-lint": "^0.9.2",
-    "phpunit/phpunit": "^6.0",
     "lookyman/coding-standard": "^0.0.5",
-    "phpstan/phpstan": "^0.7.0"
+    "phpstan/phpstan": "^0.9.0",
+    "phpunit/phpunit": "^6.4",
+    "phpstan/phpstan-phpunit": "^0.9.0"
   },
   "autoload": {
     "psr-4": {
@@ -35,7 +36,7 @@
     "lint": "parallel-lint ./src ./tests",
     "cs": "phpcs --colors --extensions=php --encoding=utf-8 -sp ./src ./tests",
     "tests": "phpunit --coverage-text",
-    "stan": "phpstan analyse -l 5 -c ./phpstan.neon ./src ./tests",
+    "stan": "phpstan analyse -l max -c ./phpstan.neon ./src ./tests",
     "check": [
       "@lint",
       "@cs",

extension.neon

@@ -8,3 +8,4 @@ services:
 	-
 		class: Lookyman\PHPStan\Symfony\Rules\ContainerInterfaceUnknownServiceRule
 		tags: [phpstan.rules.rule]
+	- Lookyman\PHPStan\Symfony\ServiceMap(%symfony.srcDevDebugProjectContainerXml%)

phpcs.xml.dist

@@ -1,4 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ruleset name="PHPStan Symfony">
-    <rule ref="vendor/lookyman/coding-standard/LookymanCodingStandard/ruleset-7.0.xml"/>
+    <rule ref="vendor/lookyman/coding-standard/LookymanCodingStandard/ruleset-7.0.xml">
+        <exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName"/>
+    </rule>
 </ruleset>

phpstan.neon

@@ -1,3 +1,3 @@
-parameters:
-	ignoreErrors:
-		- '#, PHPUnit_Framework_MockObject_MockObject given#'
+includes:
+	- vendor/phpstan/phpstan-phpunit/extension.neon
+	- vendor/phpstan/phpstan-phpunit/rules.neon

src/Rules/ContainerInterfacePrivateServiceRule.php

@@ -7,6 +7,7 @@
 use Lookyman\PHPStan\Symfony\ServiceMap;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
+use PHPStan\Type\ObjectType;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
@@ -34,16 +35,21 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$services = $this->serviceMap->getServices();
-		return $node instanceof MethodCall
-			&& $node->name === 'get'
-			&& $scope->getType($node->var)->getClass() === ContainerInterface::class
-			&& isset($node->args[0])
-			&& $node->args[0] instanceof Arg
-			&& $node->args[0]->value instanceof String_
-			&& \array_key_exists($node->args[0]->value->value, $services)
-			&& !$services[$node->args[0]->value->value]['public']
-			? [\sprintf('Service "%s" is private.', $node->args[0]->value->value)]
-			: [];
+		if ($node instanceof MethodCall && $node->name === 'get') {
+			$type = $scope->getType($node->var);
+			if (!$type instanceof ObjectType) {
+				return [];
+			}
+			return $type->getClassName() === ContainerInterface::class
+				&& isset($node->args[0])
+				&& $node->args[0] instanceof Arg
+				&& $node->args[0]->value instanceof String_
+				&& \array_key_exists($node->args[0]->value->value, $services)
+				&& !$services[$node->args[0]->value->value]['public']
+				? [\sprintf('Service "%s" is private.', $node->args[0]->value->value)]
+				: [];
+		}
+		return [];
 	}
 
 }

src/Rules/ContainerInterfaceUnknownServiceRule.php

@@ -7,6 +7,7 @@
 use Lookyman\PHPStan\Symfony\ServiceMap;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
+use PHPStan\Type\ObjectType;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
@@ -34,15 +35,20 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$services = $this->serviceMap->getServices();
-		return $node instanceof MethodCall
-			&& $node->name === 'get'
-			&& $scope->getType($node->var)->getClass() === ContainerInterface::class
-			&& isset($node->args[0])
-			&& $node->args[0] instanceof Arg
-			&& $node->args[0]->value instanceof String_
-			&& !\array_key_exists($node->args[0]->value->value, $services)
-			? [\sprintf('Service "%s" is not registered in the container.', $node->args[0]->value->value)]
-			: [];
+		if ($node instanceof MethodCall && $node->name === 'get') {
+			$type = $scope->getType($node->var);
+			if (!$type instanceof ObjectType) {
+				return [];
+			}
+			return $type->getClassName() === ContainerInterface::class
+				&& isset($node->args[0])
+				&& $node->args[0] instanceof Arg
+				&& $node->args[0]->value instanceof String_
+				&& !\array_key_exists($node->args[0]->value->value, $services)
+				? [\sprintf('Service "%s" is not registered in the container.', $node->args[0]->value->value)]
+				: [];
+		}
+		return [];
 	}
 
 }

src/Type/ContainerInterfaceDynamicReturnTypeExtension.php

@@ -28,7 +28,7 @@ public function __construct(ServiceMap $symfonyServiceMap)
 		$this->serviceMap = $symfonyServiceMap;
 	}
 
-	public static function getClass(): string
+	public function getClass(): string
 	{
 		return ContainerInterface::class;
 	}

tests/Type/ContainerInterfaceDynamicReturnTypeExtensionTest.php

@@ -34,7 +34,7 @@ public function testImplementsDynamicMethodReturnTypeExtension()
 	public function testGetClass()
 	{
 		$extension = new ContainerInterfaceDynamicReturnTypeExtension(new ServiceMap(__DIR__ . '/../container.xml'));
-		self::assertEquals(ContainerInterface::class, $extension::getClass());
+		self::assertEquals(ContainerInterface::class, $extension->getClass());
 	}
 
 	public function testIsMethodSupported()