From 8efc93b90d5752040c7a0e780326d6cb72da124e Mon Sep 17 00:00:00 2001 From: RomainLvr Date: Fri, 10 Jan 2025 16:31:23 +0100 Subject: [PATCH 1/2] Fix display when otherserial is null --- inc/change_item.class.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/inc/change_item.class.php b/inc/change_item.class.php index c8b60b1..1903666 100644 --- a/inc/change_item.class.php +++ b/inc/change_item.class.php @@ -129,8 +129,8 @@ public static function pdfForChange(PluginPdfSimplePDF $pdf, Change $change) Toolbox::stripTags(sprintf(__('%1$s: %2$s'), $typename, $nb)), Toolbox::stripTags($name), Dropdown::getDropdownName('glpi_entities', $data['entity']), - Toolbox::stripTags($data['serial']), - Toolbox::stripTags($data['otherserial']), + Toolbox::stripTags((string)$data["serial"]), + Toolbox::stripTags((string)$data["otherserial"]), $nb, ); } else { @@ -138,8 +138,8 @@ public static function pdfForChange(PluginPdfSimplePDF $pdf, Change $change) '', Toolbox::stripTags($name), Dropdown::getDropdownName('glpi_entities', $data['entity']), - Toolbox::stripTags($data['serial']), - Toolbox::stripTags($data['otherserial']), + Toolbox::stripTags((string)$data["serial"]), + Toolbox::stripTags((string)$data["otherserial"]), $nb, ); } From 1904d1a023f59e705336d7497fd41688b717eb7c Mon Sep 17 00:00:00 2001 From: RomainLvr Date: Fri, 10 Jan 2025 17:37:58 +0100 Subject: [PATCH 2/2] Fix PHP Lint --- inc/change_item.class.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/inc/change_item.class.php b/inc/change_item.class.php index 1903666..9475d09 100644 --- a/inc/change_item.class.php +++ b/inc/change_item.class.php @@ -129,8 +129,8 @@ public static function pdfForChange(PluginPdfSimplePDF $pdf, Change $change) Toolbox::stripTags(sprintf(__('%1$s: %2$s'), $typename, $nb)), Toolbox::stripTags($name), Dropdown::getDropdownName('glpi_entities', $data['entity']), - Toolbox::stripTags((string)$data["serial"]), - Toolbox::stripTags((string)$data["otherserial"]), + Toolbox::stripTags((string) $data["serial"]), + Toolbox::stripTags((string) $data["otherserial"]), $nb, ); } else { @@ -138,8 +138,8 @@ public static function pdfForChange(PluginPdfSimplePDF $pdf, Change $change) '', Toolbox::stripTags($name), Dropdown::getDropdownName('glpi_entities', $data['entity']), - Toolbox::stripTags((string)$data["serial"]), - Toolbox::stripTags((string)$data["otherserial"]), + Toolbox::stripTags((string) $data["serial"]), + Toolbox::stripTags((string) $data["otherserial"]), $nb, ); }