Bug at "--period" option

[asangphukieo]

Hi,
I tried the new mode "--period" option and found small bug in the main.py script at line 540.
It shows "period" parameter not defind.
To fix this, I just removed Line 540-543, and the script works!

if (ap.period < 0):
msg = (f"Argument period is non-negative integer-value, but you have "
f"specified {ap.period}. O will be used instead.")
sys.stderr.write(msg)

Thank you for your nice tool.
Apiwat

[polyactis]

We fixed the bug and tested it. Please try the new docker image. -- Yu S. Huang http://www.yfish.org/ https://sites.google.com/site/polyactis/

…

On Tue, Mar 1, 2022 at 10:12 AM asangphukieo ***@***.***> wrote: Hi, I tried the new mode "--period" option and found small bug in the main.py script at line 540. It shows "period" parameter not defind. To fix this, I just removed Line 540-543, and the script works! if (ap.period < 0): msg = (f"Argument period is non-negative integer-value, but you have " f"specified {ap.period}. O will be used instead.") sys.stderr.write(msg) Thank you for your nice tool. Apiwat — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF7C2IQWAIQQKPVUP72VN3U5V4KVANCNFSM5PSXCLGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[polyactis]

Also let us know how different the period estimated is from the one from imaging/expert-viewing.

…

On Wed, Mar 2, 2022 at 7:58 PM Yu Huang ***@***.***> wrote: We fixed the bug and tested it. Please try the new docker image. -- Yu S. Huang http://www.yfish.org/ https://sites.google.com/site/polyactis/ On Tue, Mar 1, 2022 at 10:12 AM asangphukieo ***@***.***> wrote: > Hi, > I tried the new mode "--period" option and found small bug in the main.py > script at line 540. > It shows "period" parameter not defind. > To fix this, I just removed Line 540-543, and the script works! > > if (ap.period < 0): > msg = (f"Argument period is non-negative integer-value, but you have " > f"specified {ap.period}. O will be used instead.") > sys.stderr.write(msg) > > Thank you for your nice tool. > Apiwat > > — > Reply to this email directly, view it on GitHub > <#17>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAF7C2IQWAIQQKPVUP72VN3U5V4KVANCNFSM5PSXCLGQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[polyactis]

Your hack worked but the parameter wasn't passed down to the C++ program "infer". I recommend you pull the image and run it again. :)

…

On Tue, Mar 1, 2022 at 10:12 AM asangphukieo ***@***.***> wrote: Hi, I tried the new mode "--period" option and found small bug in the main.py script at line 540. It shows "period" parameter not defind. To fix this, I just removed Line 540-543, and the script works! if (ap.period < 0): msg = (f"Argument period is non-negative integer-value, but you have " f"specified {ap.period}. O will be used instead.") sys.stderr.write(msg) Thank you for your nice tool. Apiwat — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF7C2IQWAIQQKPVUP72VN3U5V4KVANCNFSM5PSXCLGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[asangphukieo]

Ohh, tank you very much
I will let you know the result soon.