Skip to content

<outlook not="unexpected value"> stops the conditional rendering #193

@cossssmin

Description

@cossssmin

Originally created in maizzle/framework by @mconnell


Discovered through an accident in the documentation..

The documentation for <outlook> (https://maizzle.com/docs/tags#outlook) lists an optional not attribute. Thinking that the <outlook> tag was emitting <!--[if mso|ie]> the thought was to apply the following:

<outlook not="ie">
  Some markup
</outlook>

Ignoring the documentation was slightly wrong, the potential bug/issue is that when an unexpected value is passed to the not attribute, the MSO conditional isn't rendered at all. Instead we just get:

  Some markup

I think the desired behaviour should be for the tag to ignore the bad value and still generate the conditional e.g.

<!--[if mso|ie]>
  Some markup
<![endif]-->

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions