Skip to content

napi is no longer output as a tag #79

@strazzere

Description

@strazzere

I'm unsure if this was intentional when setting napi to default, and upstream tools are meant to just "assume" that everything is napi, however this change;

7b6dcbd#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L114-L116

Is causing prebuilt binaries to not be detected, at a minimum, by people using the tooling in node-gyp-prebuilt. E.g. -- node-usb node-usb/node-usb#743

I can submit PR with a testcase and fix for this, if you deem this an oversight on the previous patch. However if not, and this is working as intended, would you be open to a PR to enable outputing napi explicitly? I'm not overly familiar with node-gyp style prebuilds and can't tell if this was intended or not. It seems more like a bug to me.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions